-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working when multiple workflows are triggered by a commit #26
Comments
I'm also experiencing this |
Hi @zolex, thanks for your report! What happens if you call the Checks differently? (it looks like both are called "Build Image"?) |
Might be related to https://git.luolix.topmunity/t/specify-check-suite-when-creating-a-checkrun/118380/18 The check-run seems to be posted under the wrong suite when pointing at a different commit or outside job |
Yeah, looks like it. |
Is there an update on this? |
@lukasmalkmus I am not sure if there is any way to fix this as it looks like an issue from GitHub (we can't specify the suite when creating a Check, instead we rely only on the SHA and hope that GitHub does the correlation correctly, which it doesn't always). |
We have been able to solve this problem, using the token of a GitHub App (instead of GITHUB_TOKEN). In this way, the check run is associated with a specific new check suite associated with the GitHub App. We use this other action to generate a temporally GitHub App token for use in the workflow https://github.com/peter-murray/workflow-application-token-action This configuration must also be taken into account in the repo settings. |
When you have have multiple workflows that can be triggered by the same commit, the checks-action only adds the checks to the first executed workflow.
here is the debug output of the first exectued workflow, that was able to add the run-check in it's summary:
the summary then looks like this:
and here is the debug output another workflow run that is triggered by the same commit but runs after the first workflow (same result for all but the first)
in this workflow the run-checks are not displayed/not added to the run, though the debug output says everything was working fine....
The text was updated successfully, but these errors were encountered: