{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":290188301,"defaultBranch":"main","name":"common","ownerLogin":"Luap99","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2020-08-25T10:47:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/45212748?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1719308468.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"7352ee1aba8bbaf71be3bd5adb4c238585cd045d","ref":"refs/heads/metric","pushedAt":"2024-06-25T09:41:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork/netavark: fix rootless unit tests\n\nCommit 26fc823c27 added check for the env var inside the network\ninterface setup code as this is something that is always set by podman.\nHowever if you try to run the unit tests as rootless they now always\nfailed as the code assumed we have access to a rootful path.\n\nThe easy fix is to just fix the test to set the env when running\nrootless.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork/netavark: fix rootless unit tests"}},{"before":"b81d27cd5321882de04db522125c98c8e3c1e938","after":null,"ref":"refs/heads/registry.k8s.io","pushedAt":"2024-06-18T11:16:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":null,"after":"b81d27cd5321882de04db522125c98c8e3c1e938","ref":"refs/heads/registry.k8s.io","pushedAt":"2024-06-18T09:39:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"replace k8s.gcr.io with registry.k8s.io\n\nWe see issues in CI where we fail to pull from k8s.gcr.io. As k8s uses a\nnew registry URL migrate to that[1] and hope it fixes the issues.\n\n[1] https://kubernetes.io/blog/2023/02/06/k8s-gcr-io-freeze-announcement/\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"replace k8s.gcr.io with registry.k8s.io"}},{"before":"67fdd8bd3aa912efa9d8a6375c6b5d192d4f8f9a","after":null,"ref":"refs/heads/rootlessnetns-run","pushedAt":"2024-06-12T14:21:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":null,"after":"67fdd8bd3aa912efa9d8a6375c6b5d192d4f8f9a","ref":"refs/heads/rootlessnetns-run","pushedAt":"2024-06-05T09:42:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork/rootlessnetns: create run dir explicitly\n\nCurrently it does the mkdir only implicitly because the code creates\nrun/systemd but this only happens when /run/systemd exists on the host.\nAs such the rootless code was broken on all non systemd distros[1].\n\n[1] https://github.com/containers/podman/discussions/22903\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork/rootlessnetns: create run dir explicitly"}},{"before":"3e57a6a9002c8a41500d41a727881644b9d3a443","after":null,"ref":"refs/heads/v0.59-backports","pushedAt":"2024-05-31T17:53:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":"d73b3300c6f413a544547d2d78e668a89ffde022","after":"3e57a6a9002c8a41500d41a727881644b9d3a443","ref":"refs/heads/v0.59-backports","pushedAt":"2024-05-31T13:31:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"fix windows config path regression\n\nThe path no longer included the path separator between the env and our\nconfig dir. The regression was added in commit 6c651dfac1.\n\nFixes #2025\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"fix windows config path regression"}},{"before":null,"after":"d73b3300c6f413a544547d2d78e668a89ffde022","ref":"refs/heads/v0.59-backports","pushedAt":"2024-05-31T13:18:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libimage/manifests.list.Add(): preserve artifactType when all=true\n\nWhen asked to add all of the entries from one index to another, don't\nforget to carry over the artifactType.\n\nSigned-off-by: Nalin Dahyabhai <nalin@redhat.com>","shortMessageHtmlLink":"libimage/manifests.list.Add(): preserve artifactType when all=true"}},{"before":"0c060259a578ebb6fd695cf1a8e23a9131d42b1a","after":null,"ref":"refs/heads/firewall-doc","pushedAt":"2024-05-31T13:14:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":null,"after":"0c060259a578ebb6fd695cf1a8e23a9131d42b1a","ref":"refs/heads/firewall-doc","pushedAt":"2024-05-31T10:23:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"fix outdated firewall_driver docs\n\nnftables was implemented for netavark v1.10\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"fix outdated firewall_driver docs"}},{"before":"7490d3ddd122d971f7f25c82e1b5acb31ed4173e","after":null,"ref":"refs/heads/winpath","pushedAt":"2024-05-30T16:55:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":"0093c7b722a983bfb99c6930e5ceef1917337546","after":"7490d3ddd122d971f7f25c82e1b5acb31ed4173e","ref":"refs/heads/winpath","pushedAt":"2024-05-30T15:48:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"fix windows config path regression\n\nThe path no longer included the path separator between the env and our\nconfig dir. The regression was added in commit 6c651dfac1.\n\nFixes #2025\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"fix windows config path regression"}},{"before":null,"after":"0093c7b722a983bfb99c6930e5ceef1917337546","ref":"refs/heads/winpath","pushedAt":"2024-05-30T15:47:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"fix windows config path regression\n\nThe path no longer included the path seperator between the env and our\nconfig dir. The regession was added in commit 6c651dfac1.\n\nFixes #2025\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"fix windows config path regression"}},{"before":"26fc823c276540ef9022fa10956496a9f43cab74","after":null,"ref":"refs/heads/rootlessnetns-env","pushedAt":"2024-05-28T15:50:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":"b7b4837dd9ee3a91630d8e6a87278c25b8880d7a","after":"26fc823c276540ef9022fa10956496a9f43cab74","ref":"refs/heads/rootlessnetns-env","pushedAt":"2024-05-27T13:19:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork: fix rexec env check for rootlessnetns\n\nFor some unknown reason the podman container image sets the\n_CONTAINERS_USERNS_CONFIGURED env to an empty value. I don't know what\nthe purpose of this is but is will trigger the check here which is wrong\nwhen the container is privileged.\n\nTo fix this check that the value is set to done like it is by the reexec\nlogic. Also make sure the lock dir uses the same condition to stay\nconsistent.\n\nFixes containers/podman#22791\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork: fix rexec env check for rootlessnetns"}},{"before":null,"after":"b7b4837dd9ee3a91630d8e6a87278c25b8880d7a","ref":"refs/heads/rootlessnetns-env","pushedAt":"2024-05-27T13:18:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork: fix rexec env check for rootlessnetns\n\nFor some unknonw reason the podman container image sets the\n_CONTAINERS_USERNS_CONFIGURED env to an empty value. I don't know what\nthe purpose of this is but is will trigger the check here which is wrong\nwhen the contianer is privileged.\n\nTo fix this check that the value is set to done like it is by the reexec\nlogic. Also make sure the lock dir uses the same condition to stay\nconsitent.\n\nFixes containers/podman#22791\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork: fix rexec env check for rootlessnetns"}},{"before":"fca82ba7f18f1b1bb496c8df8e3ebc828a2cc607","after":null,"ref":"refs/heads/rootlessnetns-info","pushedAt":"2024-05-17T08:49:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":"019cb750a797257e8ba63ca6a858d66037e0c15c","after":null,"ref":"refs/heads/dnsname-test","pushedAt":"2024-05-17T08:49:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":"ee0734fae41d708315f767a2dece6211fb435007","after":"fca82ba7f18f1b1bb496c8df8e3ebc828a2cc607","ref":"refs/heads/rootlessnetns-info","pushedAt":"2024-05-16T13:24:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork: add option to return rootless-netns ips\n\nWhen using the bridge network mode as rootless we use the rootless netns\nlogic, for podman this looks like just as using bridge as root. The\nissue is however due the extra namespace we block certain address there.\nThis can be seen best with pasta but actually effects other cases too.\nThe podman logic tries to use any host ip address for\nhost.containers.internal but we must make sure to exculde all these\naddress in the rootless netns as they are not actually the hostns as\nthus cause great confusion.\n\nFor the --network pasta case I already fixed this by returning the ips on\nthe pasta.Setup2() call in b809d7231132.\nFor the bridge mode this more complicated due several layers of function\ncalls. I decided to implement this as extra function call on the interface\nto return the ips as this makes the usage in podman the easiest. And I\nalso didn't want to break the API as we only have to fix this in podman\nnot buildah.\n\nIt is needed to address #22653 but it needs podman changes as well to\nuse this new function.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork: add option to return rootless-netns ips"}},{"before":"5bd9dee54d6cb857cfececdebde5dab1bc9fb2a4","after":"ee0734fae41d708315f767a2dece6211fb435007","ref":"refs/heads/rootlessnetns-info","pushedAt":"2024-05-16T13:10:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork: add option to return rootless-netns ips\n\nWhen using the bridge network mode as rootless we use the rootless netns\nlogic, for podman this looks like just as using bridge as root. The\nissue is however due the extra namespace we block certain address there.\nThis can be seen best with pasta but actually effects other cases too.\nThe podman logic tries to use any host ip address for\nhost.containers.internal but we must make sure to exculde all these\naddress in the rootless netns as they are not actually the hostns as\nthus cause great confusion.\n\nFor the --network pasta case I already fixed this by returning the ips on\nthe pasta.Setup2() call in b809d7231132.\nFor the bridge mode this more complicated due several layers of function\ncalls. I decided to implement this as extra function call on the interface\nto return the ips as this makes the usage in podman the easiest. And I\nalso didn't want to break the API as we only have to fix this in podman\nnot buildah.\n\nIt is needed to address #22653 but it needs podman changes as well to\nuse this new function.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork: add option to return rootless-netns ips"}},{"before":"10ffb79057387f6da34de125166c11f719ec5765","after":"5bd9dee54d6cb857cfececdebde5dab1bc9fb2a4","ref":"refs/heads/rootlessnetns-info","pushedAt":"2024-05-16T13:08:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork: Add option ro return rootless-netns ips\n\nWhen using the bridge network mode as rootless we use the rootless netns\nlogic, for podman this looks like just as using bridge as root. The\nissue is however due the extra namespace we block certain address there.\nThis can be seen best with pasta but actually effects other cases too.\nThe podman logic tries to use any host ip address for\nhost.containers.internal but we must make sure to exculde all these\naddress in the rootless netns as they are not actually the hostns as\nthus cause great confusion.\n\nFor the --network pasta case I already fixed this by returning the ips on\nthe pasta.Setup2() call in b809d7231132.\nFor the bridge mode this more complicated due several layers of function\ncalls. I decided to implement this as extra function call on the interface\nto return the ips as this makes the usage in podman the easiest. And I\nalso didn't want to break the API as we only have to fix this in podman\nnot buildah.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork: Add option ro return rootless-netns ips"}},{"before":null,"after":"10ffb79057387f6da34de125166c11f719ec5765","ref":"refs/heads/rootlessnetns-info","pushedAt":"2024-05-16T13:07:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork: Add option ro return rootless-netns ips\n\nWhen using the bridge network mode as rootless we use the rootless netns\nlogic, for podman this looks like just as using bridge as root. The\nissue is however due the extra namespace we block certain address there.\nThis can be seen best with pasta but actually effects other cases too.\nThe podman logic tries to use any host ip address for\nhost.containers.internal but we must make sure to exculde all these\naddress in the rootless netns as they are not actually the hostns as\nthus cause great confusion.\n\nFor the --network pasta case I already fixed this by returing the ips on\nthe pasta.Setup2() call in b809d7231132.\nFor the brisge mode this more complicated due several layers of function\ncalls. I decided to implement this as extra function call on the interface\nto return the ips as this makes the usage in podman the easiest. And I\nalso didn't want to break the API as we only have to fix this in podman\nnot buildah.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork: Add option ro return rootless-netns ips"}},{"before":"c0378d9773a8ec413b61eafb9aecc4aab0f0b13d","after":"019cb750a797257e8ba63ca6a858d66037e0c15c","ref":"refs/heads/dnsname-test","pushedAt":"2024-05-15T16:29:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"CI: update VM to fedora 40\n\nAlso removes the podman-plugins (dnsname) package.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"CI: update VM to fedora 40"}},{"before":null,"after":"c0378d9773a8ec413b61eafb9aecc4aab0f0b13d","ref":"refs/heads/dnsname-test","pushedAt":"2024-05-15T16:26:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"CI: update VM to fedora 40\n\nAlso removes the podman-plugins (dnsname) package.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"CI: update VM to fedora 40"}},{"before":"917c5837ee41dd63303d43cc4a23b9f0bb359ca3","after":null,"ref":"refs/heads/map-gw","pushedAt":"2024-04-26T08:57:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":"11d833b521e8414090cd982a246324d17c32d227","after":null,"ref":"refs/heads/docker-26","pushedAt":"2024-04-25T17:38:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"}},{"before":"6b44fc7426b730ed36d8ab270eb6c71eed635d45","after":"11d833b521e8414090cd982a246324d17c32d227","ref":"refs/heads/docker-26","pushedAt":"2024-04-25T14:18:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"Fix missing build tag for c/storage\n\nWe do not have a new c/storage here so we still try to use devicemapper\nby default in the lint task, make sure it is disabled.\n\nThis got broken after commit cd7e39eba2 which remove the dep from the\ninstall.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"Fix missing build tag for c/storage"}},{"before":"b35aaba8bca2822cc93d82fedf4963e2b7b23b33","after":"6b44fc7426b730ed36d8ab270eb6c71eed635d45","ref":"refs/heads/docker-26","pushedAt":"2024-04-25T13:39:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"vendor: update module github.com/docker/docker to v26\n\nFor some reason the renovate PR does incorrect vendoring:\nhttps://github.com/containers/common/pull/1925\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"vendor: update module github.com/docker/docker to v26"}},{"before":null,"after":"b35aaba8bca2822cc93d82fedf4963e2b7b23b33","ref":"refs/heads/docker-26","pushedAt":"2024-04-25T13:34:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"vendor: update module github.com/docker/docker to v26\n\nFor some reason the renovate PR does incorrect vendoring:\nhttps://github.com/containers/common/pull/1925\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"vendor: update module github.com/docker/docker to v26"}},{"before":"3261227b01456c2cf0a1a0ff28daadf534c67fb4","after":"917c5837ee41dd63303d43cc4a23b9f0bb359ca3","ref":"refs/heads/map-gw","pushedAt":"2024-04-25T13:07:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Luap99","name":"Paul Holzinger","path":"/Luap99","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45212748?s=80&v=4"},"commit":{"message":"libnetwork/pasta: fix multiple --map-gw parsing\n\nIt is possible for a user to set --map-gw more than once so we should\nhandle it correctly.\n\nSigned-off-by: Paul Holzinger <pholzing@redhat.com>","shortMessageHtmlLink":"libnetwork/pasta: fix multiple --map-gw parsing"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEbm5PvwA","startCursor":null,"endCursor":null}},"title":"Activity · Luap99/common"}