-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eBUSd version to 24.1.0 #153
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes in this pull request involve updating the version information for the EBUSd application. Specifically, a new version entry for EBUSd 24.1.0 has been added to the changelog, along with its corresponding header. Additionally, the version number in the configuration file has been updated from "23.2.6" to "24.1.0". The overall structure and content of both files remain unchanged apart from these version updates. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
ebusd/CHANGELOG.md
(1 hunks)ebusd/config.yaml
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
ebusd/CHANGELOG.md
2-2: null
First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🔇 Additional comments (2)
ebusd/config.yaml (1)
2-2
: Verify docker image version alignment
The version has been bumped from 23.2.6 to 24.1.0. Let's verify this matches the referenced docker image.
✅ Verification successful
Version alignment confirmed between config and package
The version bump to 24.1.0 in config.yaml aligns correctly with the ebusd package version 24.1-r0 specified in the Dockerfile. The add-on uses the Alpine package repository to install ebusd, and the version numbers match (24.1.x). The image versioning is handled through the Home Assistant build system using the base images defined in build.yaml.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if the docker image for version 24.1.0 exists
# Note: Using GitHub Container Registry (ghcr.io) as specified in the image field
# Check if the image exists for all supported architectures
for arch in armhf armv7 aarch64 amd64 i386; do
echo "Checking image for $arch..."
gh api \
-H "Accept: application/vnd.oci.image.index.v1+json" \
"/v2/lukasgrebe/ha-addon-ebusd-$arch/tags/list" | \
jq '.tags[] | select(. == "24.1.0")'
done
Length of output: 2172
Script:
#!/bin/bash
# Let's first check the Dockerfile and config to understand the image reference
echo "=== Checking config.yaml ==="
cat ebusd/config.yaml
echo -e "\n=== Checking Dockerfile ==="
cat ebusd/Dockerfile
echo -e "\n=== Checking build.yaml if exists ==="
cat ebusd/build.yaml 2>/dev/null || echo "build.yaml not found"
Length of output: 3103
ebusd/CHANGELOG.md (1)
2-4
: Version consistency verified
The version "24.1.0" is consistently reflected in both config.yaml and CHANGELOG.md.
🧰 Tools
🪛 Markdownlint (0.37.0)
2-2: null
First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change, ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I guess @LukasGrebe needs to approve as well.
The eBUSd docker image was recently updated to 24.1, but it's not possible to update in Home Assistant, presumably because the version wasn't bumped.
Resolves #151
Summary by CodeRabbit