Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog labels incorrect #1161

Closed
sr258 opened this issue Jan 13, 2021 · 2 comments · Fixed by #1171
Closed

Dialog labels incorrect #1161

sr258 opened this issue Jan 13, 2021 · 2 comments · Fixed by #1171
Labels
released [type] bug Something isn't working (resulting in patch-version)

Comments

@sr258
Copy link
Member

sr258 commented Jan 13, 2021

The way language strings are fetched for the core editor is broken, and the language strings for the confirmation dialogs don't display correctly.

@sr258 sr258 added the [type] bug Something isn't working (resulting in patch-version) label Jan 13, 2021
@sr258
Copy link
Member Author

sr258 commented Jan 14, 2021

This only happens in the released package version, so the loadPath to the language files seems to be incorrect for the release package.

It is set here:

'node_modules/@lumieducation/h5p-server/build/assets/translations/{{ns}}/{{lng}}.json'

I guess there must be some prefix if you use the release package. The files can be found in resources/app/node_modules... in the release package.

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [type] bug Something isn't working (resulting in patch-version)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant