Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix judgement chart overcounting breaks #610

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Fix judgement chart overcounting breaks #610

merged 2 commits into from
Aug 22, 2024

Conversation

LumpBloom7
Copy link
Owner

Fixes #609

Two things contributed to excess breaks

  1. Holds are counted as well, despite the Break not applying to itself, but the nested Hold.head object
  2. Slides are also wrapper objects that are incorrectly counted. (The break property is applied to the nested tap object)

@LumpBloom7 LumpBloom7 added the bug Something isn't working label Aug 14, 2024
@LumpBloom7 LumpBloom7 merged commit cc6f35b into master Aug 22, 2024
3 checks passed
@LumpBloom7 LumpBloom7 deleted the FixOvercountedBreaks branch August 22, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency between number of break bonuses and number of breaks in judgement chart
1 participant
@LumpBloom7