Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix judgement chart overcounting breaks #610

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Fix judgement chart overcounting breaks #610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f37f1
Fix break hold tails being counted as breaks in statistics
LumpBloom7 Aug 14, 2024
1c72eae
Fix Slide wrapping object being counted as breaks as well
LumpBloom7 Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions osu.Game.Rulesets.Sentakki/Statistics/JudgementChart.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ public partial class JudgementChart : FillFlowContainer
private static readonly (string, Func<HitEvent, bool>)[] entries =
{
("Tap", e => e.HitObject is Tap x && !x.Break),
("Hold", e => (e.HitObject is Hold or Hold.HoldHead) && !((SentakkiLanedHitObject)e.HitObject).Break),
("Hold", e => ((e.HitObject is Hold.HoldHead) && !((SentakkiLanedHitObject)e.HitObject).Break) || e.HitObject is Hold),
("Slide", e => e.HitObject is SlideBody x),
("Touch", e => e.HitObject is Touch),
("Touch Hold", e => e.HitObject is TouchHold),
("Break", e => e.HitObject is SentakkiLanedHitObject x && x.Break),
// Note Hold and Slide breaks are applied to child objects, not itself.
("Break", e => e.HitObject is SentakkiLanedHitObject x && (x is not Hold) && (x is not Slide) && x.Break),
};

private readonly IReadOnlyList<HitEvent> hitEvents;
Expand Down
Loading