Improve colors?

[alloc33]

I really like this color scheme, however I think there are a few places where the colors could be better (compared to the navrasu/onedark color scheme). Should the colors be different here?

[akinsho]

(compared to the navrasu/onedark color scheme)

Not sure comparison to another colorscheme is right here, since I don't think an aim of a port of the horizon theme should be compared to a pretty different theme.

Although I agree that there's, arguably, an issue. I've seen whilst using other themes that were ported to neovim that Variable gets highlighted which nvim-treesitter links to TSVariable meaning that you end with a whole file that has that specific colour since variables are super common. I think a default exception for all themes should be to not highlight TSVariable as anything other than Normal (IMO ofc), unless it's a special variable like variable.builtin → TSVariableBuiltin

A "fix" I'm using personally is to set TSVariable to match Normal 🤷🏿

[akinsho]

For posterity, think I was wrong about this. I do think in most cases highlighting TSVariable is noisy, but although it doesn't use treesitter, so the effect isn't really the same, vscode's version of the theme does use this much red. So I actually think this is probably a true to life replication of the theme, I opened a few files in both editors to check.

[alloc33]

I want to reopen this issue, I use this color scheme every day but I don't have enough knowledge to achieve what I want (described in the 1st issue post). @ChristianChiarulli do you have any idea how we can improve this? I would have made all the changes myself if I knew exactly where to look for the problem