Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icons and props for controls #37

Open
LunatiqueCoder opened this issue Jan 15, 2023 · 7 comments
Open

Custom icons and props for controls #37

LunatiqueCoder opened this issue Jan 15, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@LunatiqueCoder
Copy link
Owner

LunatiqueCoder commented Jan 15, 2023

  • The icons should be perhaps extracted in another npm package so users can choose if they want to use the default icons or their custom ones.
  • The user should be able to pass props to the control or to the icon (image).
@LunatiqueCoder LunatiqueCoder added the enhancement New feature or request label Jan 15, 2023
@LunatiqueCoder LunatiqueCoder self-assigned this Jan 15, 2023
@LunatiqueCoder LunatiqueCoder moved this to Todo in 3.0.0 Jan 15, 2023
@poojan010
Copy link

can you add props like renderPlayIcon, renderPauseIcon, renderForwardIcon, renderReplayIcon
so user can set icons according to there need
they can even use vector icons there

@TomPrice2023
Copy link

Hi, just wondering if there has been any progress on this enhancement or if it is something you would be open to have contributors look into. Thanks for all the work you've put into this package!

@LunatiqueCoder
Copy link
Owner Author

Hey @TomPrice2023 . Unfortunately there hasn't been made any progress, but in case the community requires it, it can gain a higher priority. Is it something you need?

@TomPrice2023
Copy link

Hi @LunatiqueCoder, thank you for the update! I definitely think it would be very useful. The package is awesome and being able to align the end result to what the designers have mocked up would be perfect! I'd also be curious to see if positioning icons is something that this enhancement could make possible.

Thanks again!

@LunatiqueCoder
Copy link
Owner Author

LunatiqueCoder commented Mar 16, 2023

@TomPrice2023 I think repositioning would be a littler bit harder. I am curious what's your use case more precisely? Maybe we can find an easy implementation.

@TomPrice2023
Copy link

The positioning would revolve around the controls which sit in the corners: full screen, volume, back. I was thinking something along the lines of topLeft, topRight, bottomLeft & bottomRight mapping to each control could maybe add a nice bit of flexibility to how the player looks.

@LunatiqueCoder LunatiqueCoder changed the title Custom icons Custom icons and props for controls Mar 17, 2023
@LunatiqueCoder
Copy link
Owner Author

@TomPrice2023 This is actually a nice idea but we have to think very well about it. Probably won't be something to expect soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants