Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Potential silent data drop? #152

Closed
fleborne opened this issue Aug 10, 2022 · 1 comment
Closed

[BUG] Potential silent data drop? #152

fleborne opened this issue Aug 10, 2022 · 1 comment
Assignees
@nicolas-rabault
Labels
bug
Milestone
2.2.4

Comments

@fleborne
Copy link
Contributor

Describe the bug

Looking at https://github.com/Luos-io/Pyluos/blob/master/pyluos/io/serial_io.py#L131, it seems to me that PyLuos may drop data silently if the queue becomes full.

If I'm correct, wouldn't it be better to consider this case as a real issue and warn the user, or even raise an exception?
@fleborne fleborne added the bug label Aug 10, 2022
@JeromeGalan JeromeGalan added this to the 2.2.4 milestone Aug 30, 2022
@JeromeGalan
Copy link
Member

Done in 2.6.0

@JeromeGalan JeromeGalan mentioned this issue Sep 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolas-rabault nicolas-rabault

Labels
bug
Projects
None yet
Milestone
2.2.4
Development

No branches or pull requests
3 participants
@nicolas-rabault @fleborne @JeromeGalan