-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlinkined paths like stable
and latest
dont work on some repos but not others
#81
Comments
stable
and latest
paths dont workstable
and latest
dont work
Https://asinghvi17.github.io/SwarmMakie.jl/stable was just built yesterday and seems to work - I have no clue where this is coming from for certain repos! |
Your repos are all switching to the version url, for some reason DD is trying to keep the pretty url I guess the only difference is DD has a custom vitepress config? |
Or is there some other setting? |
It happens here too! https://luxdl.github.io/DocumenterVitepress.jl/stable/ |
hmm, it might be the custom config - let me diff the DV and DD ones with the template, which seems to operate correctly... |
Yeah that's just the description, should be fixed in #80 |
stable
and latest
dont workstable
and latest
dont work on some repos but not others
This is better. vuejs/vitepress#1918. I don't have a lot of time today to test it. But, this might be it. |
Removing the links in the Features https://github.com/LuxDL/Lux.jl/pull/571/files#diff-36c852523b6a7513a10b8a6bae21f1037eaa27484efc9042f75bbda46d9f529b seems to have fixed the hydration error in most of the lux pages, but when redirecting from stable it still has some hydration errors: |
(wouldn't recommend this) but if someone desperately needs a workaround till it is properly resolved, manually fixing the symlinks before deploying fixes the deployment https://github.com/LuxDL/Lux.jl/blob/daf571ac359fe602ba9ef773c444298c66bb1378/.github/workflows/DeployDocs.yml#L36-L39 |
which links is exactly fixing this? Edit: 🤯 , the issue is setting |
Makes all the symlinks into actual directories and recurses through all the files changes for example, Just changing the symlinks into proper directories does nothing. |
- Mitigate LuxDL/DocumenterVitepress.jl#81 - Keep the `gh-pages` branch small
- Mitigate LuxDL/DocumenterVitepress.jl#81 - Keep the `gh-pages` branch small
I am unsure how to resolve this in my repo. I use |
Is this commit from @lazarusA also a solution? |
no, it didn't worked 😢 . But, there is a solution here: rafaqz/Rasters.jl#709, this should be documented here, at some point. |
That solved it. Thanks! <3 |
These get a 404 (after initially flashing the right page):
https://rafaqz.github.io/DimensionalData.jl/stable/
https://rafaqz.github.io/DimensionalData.jl/latest/
But
dev
works because it actually has a folder in the file system in thegh-pages
branchhttps://rafaqz.github.io/DimensionalData.jl/dev/
I'm not sure what to do about this.
The text was updated successfully, but these errors were encountered: