Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinkined paths like stable and latest dont work on some repos but not others #81

Open
rafaqz opened this issue Mar 23, 2024 · 20 comments · May be fixed by #109
Open

Symlinkined paths like stable and latest dont work on some repos but not others #81

rafaqz opened this issue Mar 23, 2024 · 20 comments · May be fixed by #109
Labels
bug Something isn't working

Comments

@rafaqz
Copy link

rafaqz commented Mar 23, 2024

These get a 404 (after initially flashing the right page):

https://rafaqz.github.io/DimensionalData.jl/stable/
https://rafaqz.github.io/DimensionalData.jl/latest/

But dev works because it actually has a folder in the file system in the gh-pages branch
https://rafaqz.github.io/DimensionalData.jl/dev/

I'm not sure what to do about this.

@rafaqz rafaqz changed the title Symlinkined paths like stable and latest paths dont work Symlinkined paths like stable and latest dont work Mar 23, 2024
@asinghvi17
Copy link
Collaborator

asinghvi17 commented Mar 23, 2024

Https://asinghvi17.github.io/SwarmMakie.jl/stable was just built yesterday and seems to work - I have no clue where this is coming from for certain repos!

@rafaqz
Copy link
Author

rafaqz commented Mar 23, 2024

Your repos are all switching to the version url, for some reason DD is trying to keep the pretty url /stable and it fails.

I guess the only difference is DD has a custom vitepress config?

@rafaqz
Copy link
Author

rafaqz commented Mar 23, 2024

Or is there some other setting?

@rafaqz
Copy link
Author

rafaqz commented Mar 23, 2024

It happens here too! https://luxdl.github.io/DocumenterVitepress.jl/stable/

@asinghvi17
Copy link
Collaborator

hmm, it might be the custom config - let me diff the DV and DD ones with the template, which seems to operate correctly...

@lazarusA
Copy link
Collaborator

Screenshot 2024-03-25 at 20 39 05 it looks like one of those REPLACE_ME things is still not getting applied properly.

@lazarusA
Copy link
Collaborator

not the cause, also happens in the good landing page:
Screenshot 2024-03-25 at 20 43 39

@asinghvi17
Copy link
Collaborator

Yeah that's just the description, should be fixed in #80

@lazarusA
Copy link
Collaborator

lazarusA commented Mar 25, 2024

Screenshot 2024-03-25 at 20 50 34

the ones that work don't have that issue of REPLACE_ME. (for favicon and description), so yeah, maybe is this thing what is messing up with the redirect.

@asinghvi17 asinghvi17 changed the title Symlinkined paths like stable and latest dont work Symlinkined paths like stable and latest dont work on some repos but not others Apr 1, 2024
@asinghvi17 asinghvi17 added the bug Something isn't working label Apr 1, 2024
@avik-pal
Copy link
Member

avik-pal commented Apr 3, 2024

It seems repos that don't have Hydration error do the symlinks correctly. But all the ones which have the error DimensionalData, Lux and Documentervitepress don't work
image
image

@lazarusA
Copy link
Collaborator

lazarusA commented Apr 3, 2024

This is better. vuejs/vitepress#1918. I don't have a lot of time today to test it. But, this might be it.

@lazarusA lazarusA linked a pull request Apr 3, 2024 that will close this issue
@avik-pal
Copy link
Member

avik-pal commented Apr 5, 2024

Removing the links in the Features https://github.com/LuxDL/Lux.jl/pull/571/files#diff-36c852523b6a7513a10b8a6bae21f1037eaa27484efc9042f75bbda46d9f529b seems to have fixed the hydration error in most of the lux pages, but when redirecting from stable it still has some hydration errors:
image

@avik-pal
Copy link
Member

avik-pal commented Apr 6, 2024

(wouldn't recommend this) but if someone desperately needs a workaround till it is properly resolved, manually fixing the symlinks before deploying fixes the deployment https://github.com/LuxDL/Lux.jl/blob/daf571ac359fe602ba9ef773c444298c66bb1378/.github/workflows/DeployDocs.yml#L36-L39

@lazarusA
Copy link
Collaborator

lazarusA commented Apr 6, 2024

which links is exactly fixing this?

Edit:

🤯 , the issue is setting base: '/repo/' ?, because those pages actually live in different versioned folders! 🤯 .

@avik-pal
Copy link
Member

avik-pal commented Apr 6, 2024

which links is exactly fixing this?

Makes all the symlinks into actual directories and recurses through all the files changes for example, v0.5.32 to stable.

Just changing the symlinks into proper directories does nothing.

thofma added a commit to thofma/Hecke.jl that referenced this issue Apr 13, 2024
- Mitigate LuxDL/DocumenterVitepress.jl#81
- Keep the `gh-pages` branch small
thofma added a commit to thofma/Hecke.jl that referenced this issue Apr 13, 2024
- Mitigate LuxDL/DocumenterVitepress.jl#81
- Keep the `gh-pages` branch small
@oameye
Copy link
Contributor

oameye commented Sep 16, 2024

I am unsure how to resolve this in my repo. I use julia-docdeploy to deploy the documtation. Will I have to change my github action to deploy-pages?

@oameye
Copy link
Contributor

oameye commented Sep 16, 2024

Is this commit from @lazarusA also a solution?

@lazarusA
Copy link
Collaborator

no, it didn't worked 😢 . But, there is a solution here: rafaqz/Rasters.jl#709, this should be documented here, at some point.

@oameye
Copy link
Contributor

oameye commented Sep 16, 2024

That solved it. Thanks! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants