Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Auto-Flattening of Chains #682

Closed
avik-pal opened this issue Jun 5, 2024 · 0 comments · Fixed by #744
Closed

Remove Auto-Flattening of Chains #682

avik-pal opened this issue Jun 5, 2024 · 0 comments · Fixed by #744
Labels
Milestone

Comments

@avik-pal
Copy link
Member

avik-pal commented Jun 5, 2024

See #681. Code becomes type unstable for Zygote if the NamedTuple has $\geq 32$ fields. We were flattening to help the zygote, but that seems to cause problems for larger models.

This is of-course extremely breaking, and will break all of the Boltz models, but I think we take that hit early on.

@avik-pal avik-pal mentioned this issue Jun 26, 2024
32 tasks
@avik-pal avik-pal added this to the v0.6 milestone Jun 28, 2024
@avik-pal avik-pal mentioned this issue Jul 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant