Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#115] Implement Binary File Attachments #116

Merged
merged 14 commits into from
Oct 2, 2023

Conversation

Luzifer
Copy link
Owner

@Luzifer Luzifer commented Oct 1, 2023

image
image
image
image

@Luzifer Luzifer linked an issue Oct 1, 2023 that may be closed by this pull request
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer Luzifer force-pushed the 115-implement-binary-file-attachments branch from f26c7ff to 90fb998 Compare October 1, 2023 11:55
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer Luzifer force-pushed the 115-implement-binary-file-attachments branch 3 times, most recently from 477d995 to cff6cc3 Compare October 1, 2023 13:05
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer Luzifer force-pushed the 115-implement-binary-file-attachments branch from cff6cc3 to 935a29b Compare October 1, 2023 13:08
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
64 MiB attachment succeeded, 70 MiB broke

Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer Luzifer force-pushed the 115-implement-binary-file-attachments branch from e7ddd7a to 926b942 Compare October 1, 2023 15:31
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer Luzifer self-assigned this Oct 1, 2023
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer Luzifer marked this pull request as ready for review October 1, 2023 16:55
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@mshedsilegx
Copy link

mshedsilegx commented Oct 2, 2023

Perfect ! I assume that opening those attachments would also invalidate (purge) them from redis, and that they would expire with the same logic than the text secret, correct ?

@mshedsilegx
Copy link

Can those attachments be added via command line driven API calls (bash script for example) as well - if yes, can an example be provided ?

@Luzifer
Copy link
Owner Author

Luzifer commented Oct 2, 2023

Perfect ! I assume that opening those attachments would also invalidate (purge) them from redis, and that they would expire with the same logic than the text secret, correct ?

They are in the same blob of data as the secret itself so when fetching the secret they are fetched along and instantly invalidated. So from clicking the "Show me the secret" button they cease to exist on the server and only exist in browser memory. You can download them multiple times as long as you don't close the tab. As soon as you close the tab they cease to exist.

Can those attachments be added via command line driven API calls (bash script for example) as well - if yes, can an example be provided ?

There is not yet an example but after this has been merged before v1.9.0 will be released I'm planning to add a CLI tool written in Go which supports attachments and secrets sharing / retrieval.

Together with that I'm gonna add a client library and markdown schema documentation how to implement the meta format.

@mshedsilegx
Copy link

Excellent.

@Luzifer Luzifer merged commit c512473 into master Oct 2, 2023
4 checks passed
@Luzifer Luzifer deleted the 115-implement-binary-file-attachments branch October 2, 2023 19:52
@Luzifer Luzifer restored the 115-implement-binary-file-attachments branch October 2, 2023 19:58
@Luzifer Luzifer deleted the 115-implement-binary-file-attachments branch October 2, 2023 19:59
@Luzifer Luzifer added this to the v1.19.x milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of binary attachments
2 participants