-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#115] Implement Binary File Attachments #116
Conversation
Luzifer
commented
Oct 1, 2023
•
edited
Loading
edited
Signed-off-by: Knut Ahlers <knut@ahlers.me>
f26c7ff
to
90fb998
Compare
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
477d995
to
cff6cc3
Compare
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
cff6cc3
to
935a29b
Compare
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
64 MiB attachment succeeded, 70 MiB broke Signed-off-by: Knut Ahlers <knut@ahlers.me>
e7ddd7a
to
926b942
Compare
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Perfect ! I assume that opening those attachments would also invalidate (purge) them from redis, and that they would expire with the same logic than the text secret, correct ? |
Can those attachments be added via command line driven API calls (bash script for example) as well - if yes, can an example be provided ? |
They are in the same blob of data as the secret itself so when fetching the secret they are fetched along and instantly invalidated. So from clicking the "Show me the secret" button they cease to exist on the server and only exist in browser memory. You can download them multiple times as long as you don't close the tab. As soon as you close the tab they cease to exist.
There is not yet an example but after this has been merged before Together with that I'm gonna add a client library and markdown schema documentation how to implement the meta format. |
Excellent. |