DllMain leaks a thread handle

[CookiePLMonster]

For completeness, the handle returned by CreateThread should be closed, so the thread doesn't stick around. It's not an issue at this scope at all, but since it can be fixed with one success check and one call, no reason not to do it either.

[Lyall]

Totally worth fixing as you say. Am I right in thinking something as simple as this would be sufficient?

BOOL APIENTRY DllMain( HMODULE hModule,
                       DWORD  ul_reason_for_call,
                       LPVOID lpReserved
                     )
{
    switch (ul_reason_for_call)
    {
    case DLL_PROCESS_ATTACH:
    {
        CreateThread(NULL, 0, Main, 0, NULL, 0);

        if (Main)
        {
            CloseHandle(Main);
        }
    }
    case DLL_THREAD_ATTACH:
    case DLL_THREAD_DETACH:
    case DLL_PROCESS_DETACH:
        break;
    }
    return TRUE;
}

You'll have to forgive me, I'm still quite the novice when it comes to C++.

[CookiePLMonster]

Main is not a handle so it needs to be something like

        HANDLE handle = CreateThread(NULL, 0, Main, 0, NULL, 0);

        if (handle != nullptr)
        {
            CloseHandle(handle);
        }

[Lyall]

Awesome, I'll add this to the next version.

    case DLL_PROCESS_ATTACH:
    {
        HANDLE mainHandle = CreateThread(NULL, 0, Main, 0, NULL, 0);

        if (mainHandle != nullptr)
        {
            CloseHandle(mainHandle);
        }
    }

[Lyall]

That's it applied in the latest release. Thank you again for the report and letting me know how to fix it.