Skip to content

Latest commit

 

History

History
186 lines (138 loc) · 6.44 KB

CONTRIBUTING.md

File metadata and controls

186 lines (138 loc) · 6.44 KB

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/LyraPhase/waybar-check-gmail/issues.

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it. Those that are tagged with "first-timers-only" is suitable for those getting started in open-source software.

Write Documentation

The project could always use more documentation, whether as part of the official docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/LyraPhase/waybar-check-gmail/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome 😊 🙏

Get Started

Ready to contribute? Here's how to set up waybar-check-gmail for local development.

  1. Fork the waybar-check-gmail repo on GitHub.

  2. Clone your fork locally:

    git clone git@github.com:your_name_here/waybar-check-gmail.git

  3. Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, this is how you set up your fork for local development:

    mkvirtualenv waybar-check-gmail cd waybar-check-gmail/  

  4. Create a branch for local development:

    git checkout -b name-of-your-bugfix-or-feature

    Now you can make your changes locally.

  5. When you're done making changes, check that they pass flake8 and the tests, including testing other Python versions with tox. In addition, ensure that your code is formatted using black:

    flake8 waybar-check-gmail tests black waybar-check-gmail tests python setup.py test # or py.test tox

    To get isort, flake8, flake8-isort, black, bandit, pytest, and tox, just pip install them into your virtualenv.

    pip install -r requirements-dev.txt

    Alternatively, you may install these via your OS package manager but beware that versions may not match those in CI/CD. You may also add pre-commit hooks for both flake8 and black to make all formatting easier. This is the method that the CI/CD pipelines use, and so is most easily replicated.

    pre-commit install

    Finally, to test multiple python versions you will need to install multiple versions side-by-side. The easiest way to do this is to use pyenv, and python-build. Note that python-build is installed by default with pyenv, but your OS may have this as a separate package. To install the versions of python this project is using:

    cat .python-version | sed -e '/^system/d' | tr '\n' ' '
    | xargs pyenv install

    Alternatively, you may select and install some other versions.

  6. Commit your changes and push your branch to GitHub:

    git add . git commit -m "Your detailed description of your changes." git push origin name-of-your-bugfix-or-feature

    In brief, commit messages should follow these conventions:

    • Always contain a subject line which briefly describes the changes made. For example "Update CONTRIBUTING.md".
    • Subject lines should ideally not exceed 50-72 characters.
    • The commit body should contain context about the change - how the code worked before, how it works now and why you decided to solve the issue in the way you did.

    More detail on commit guidelines can be found at

  7. Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. The pull request should include tests.
  2. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the list in README.md.
  3. The pull request should work for Python 3.4, 3.5, and above. Check https://github.com/LyraPhase/waybar-check-gmail/actions and make sure that the tests pass for all supported Python versions.