Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new folder browser #251

Closed
reflectronic opened this issue Dec 10, 2022 · 3 comments · Fixed by #256
Closed

Use new folder browser #251

reflectronic opened this issue Dec 10, 2022 · 3 comments · Fixed by #256

Comments

@reflectronic
Copy link
Contributor

The folder browser used by 7-Zip is still the pre-Vista style dialog created by SHBrowseForFolder:

Pre-vista style folder browser

The code could be modernized to use the new folder browser (perhaps through FolderPicker).

@MouriNaruto MouriNaruto added suggestion enhancement New feature or request labels Dec 10, 2022
@reflectronic
Copy link
Contributor Author

Would you take a pull request that implements this?

@AndromedaMelody
Copy link
Member

Thanks for your support.
NanaZip doesn't run in AppContainer, and a lots of users need run it as administrator. But Windows.Storage.Pickers can't be used in an elevated application.
You can get more information from microsoft/terminal#8957 & microsoft/terminal#9760 .

@reflectronic
Copy link
Contributor Author

Hm, that's unfortunate (ref: microsoft/WindowsAppSDK#2504). But, we could just use IFileDialog instead like Windows Terminal does; the end result is almost the same either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants