Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: use Neos\Neos\Domain\Service\FusionService->getMergedFusionObjectTree($node)? #10

Open
mhsdesign opened this issue Sep 23, 2021 · 1 comment

Comments

@mhsdesign
Copy link

Maybe with this api one would need less to rewrite. I just saw that youre not using it...
https://github.com/neos/neos-development-collection/blob/master/Neos.Neos/Classes/Domain/Service/FusionService.php#L136

But then one couldn't use this package outside of neos...

@MCStreetguy
Copy link
Owner

First of all, sorry for the late reply and thanks for the suggestion!

I also considered using this class at first, but discarded the idea because, as mentioned, it would then only make the plugin usable in the context of Neos. I'm not sure how popular this use case is in general, but at least I have used the plugin many times outside of Neos in pure flow projects and would not want to do without it.

If it's just to reduce the amount of rewritten source code, I prefer to keep the plugin separate from the CMS and continue to replicate only the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants