-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concerns regarding optimal sign determination for components #316
Comments
Would you mind posting a few more examples so that people can read them next to each other? Just like 2-3? |
Sorry for only being able to find a full presentation, but the first few slides here touch on the signing of ICA components (and why they can be arbitrarily flipped). I think this was why the original code tried to align it with the data by arbitrary transforms, but I agree that's not going to recover the "true" solution all the time. I'm not sure there is a way to do that.... Could you point me to which metrics this useful for ? |
I don't believe that the signs are used for anything except visualization (with the time series and beta weights), but I think they should be (per #318). Unfortunately, we need to ensure that the signs are appropriately determined before we can use them. Here's a list of metrics that would be affected if we used the signs for cluster extent thresholding and averaging:
It's possible that using the skew value is the best available way to do it (the GIFT toolbox says it uses skew for signing components as well), but if so I'd like to have a record as to why this is the method we must use. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to tedana:tada: ! |
I don't know if this is worth continuing to pursue. Given how we treat component signs (#318), signing the components themselves doesn't currently matter. I'll just close this issue. |
Summary
To determine the appropriate signs for PCA/ICA components in the metric calculation step, we use the signs of the skew values for weights (per component) to flip components and weights so that component time series positively align with the data. However, I am not sure that this is the best way to do this.
Additional Detail
At times, I've noticed that a component with a linear trend can be rendered as going down, instead of up. As an example, take this high-variance component from the three-echo test dataset we use for CI (returned from a run using the Kundu TEDPCA decision tree):
The text was updated successfully, but these errors were encountered: