Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m65: screenshot sometimes can fail and segfault #142

Open
lydon42 opened this issue Sep 15, 2022 · 0 comments
Open

m65: screenshot sometimes can fail and segfault #142

lydon42 opened this issue Sep 15, 2022 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@lydon42
Copy link
Member

lydon42 commented Sep 15, 2022

This is probably because of errors in the serial transmission of the memory blocks. This normally just produces glitches in the rendered image or ascii art. But the colour and character lookup helpers all have no bound checks, so it might be that some wrong value can make a lookup go out of bounds (for example out of the palette array), and therefor produce a segfault.

Quick solution will be do add bound checks to all lookup helpers in screenshot.c

Better solution will be to make serial memory dump so good that no wrong data is received.

@lydon42 lydon42 added the bug Something isn't working label Sep 15, 2022
@lydon42 lydon42 added this to the near future milestone Sep 15, 2022
@lydon42 lydon42 assigned lydon42 and unassigned lydon42 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant