Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONITOR_SAVE: make use of the m65common framework #31

Open
gurcei opened this issue Jan 31, 2021 · 1 comment
Open

MONITOR_SAVE: make use of the m65common framework #31

gurcei opened this issue Jan 31, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@gurcei
Copy link
Collaborator

gurcei commented Jan 31, 2021

@bubbob42 reported some problems compiling the monitor_save tool for mac here:

gcc -Wall -g -std=gnu99 -I/opt/local/include -L/opt/local/lib -I/usr/local/include/libusb-1.0 -L/usr/local/lib -mno-sse3 -march=x86-64 -o bin/monitor_save src/tools/monitor_save.c
src/tools/monitor_save.c:347:25: error: use of undeclared identifier 'B2000000'
    if (cfsetospeed(&t, B2000000)) perror("Failed to set output baud rate");
                        ^
src/tools/monitor_save.c:348:25: error: use of undeclared identifier 'B2000000'
    if (cfsetispeed(&t, B2000000)) perror("Failed to set input baud rate");
                        ^
src/tools/monitor_save.c:350:25: error: use of undeclared identifier 'B4000000'
    if (cfsetospeed(&t, B4000000)) perror("Failed to set output baud rate");
                        ^
src/tools/monitor_save.c:351:25: error: use of undeclared identifier 'B4000000'
    if (cfsetispeed(&t, B4000000)) perror("Failed to set input baud rate");
                        ^
4 errors generated.
make: *** [bin/monitor_save] Error 1

Seems like Paul feels this is a tool we should keep and make it use the m65common framework, so as to avoid such errors that were due to this old tool not using Paul's workaround to get higher serial-bps on Mac os-x, a workaround that already exists within the m65common library.

@lydon42 lydon42 added the enhancement New feature or request label Jul 26, 2022
@lydon42 lydon42 added this to the near future milestone Jul 26, 2022
@lydon42
Copy link
Member

lydon42 commented Jul 26, 2022

I might be already looking at this in my refactor-m65 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants