Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken on latest nightly toolchain #396

Closed
Subject38 opened this issue Feb 29, 2024 · 3 comments · Fixed by #397
Closed

Build is broken on latest nightly toolchain #396

Subject38 opened this issue Feb 29, 2024 · 3 comments · Fixed by #397

Comments

@Subject38
Copy link
Contributor

Subject38 commented Feb 29, 2024

At least two dependencies use nightly features that no longer exist: font-kit and egui (there may be more but these were the two I saw when attempting to build on latest toolchain). Updating the egui version should fix the issues but font kit will currently not compile on the latest nightly servo/font-kit#233. Opening this issue for tracking since our github CI is also broken as a result of this.

@Subject38
Copy link
Contributor Author

I'm of half a mind that we should vendor font-kit since the fix has already been done on their end but it will likely not see an actual release for a month+. I'm really not sure what the path forward should be though...

@sagudev
Copy link

sagudev commented Mar 2, 2024

You can use patch section in Cargo.toml to temporary override font-kit version from crates.io using git version. See https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

@Subject38
Copy link
Contributor Author

You can use patch section in Cargo.toml to temporary override font-kit version from crates.io using git version. See https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

I was aware that this was a thing, but am surprised nonetheless that the fix (on the fontkit side) was this simple. I just got it building on my M1 Macbook Pro running Asahi Fedora. Most of the other issues were thankfully resolved with the recent pull request being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants