Skip to content

Use CMake instead of Make #165

Closed
pavelkryukov opened this issue Sep 23, 2017 · 13 comments
Closed

Use CMake instead of Make #165

pavelkryukov opened this issue Sep 23, 2017 · 13 comments
Assignees
@SoshinK
Labels
5 Same as 4, but requires good understanding of CPU microarchitecture. infrastructure Improves build/CI infrastructure. S1 — ISA To solve the issue, you need knowledge about MIPS or RISC-V ISA

Comments

@pavelkryukov
Copy link
Member

It would be nice to replace GNU Make makefile with CMake makefile. In addition, you have to write a Wiki page explaining CMake as good as this page explains GNU Make
@pavelkryukov pavelkryukov added 3 Features of medium complexity or infrastructure enhancements code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. S1 — ISA To solve the issue, you need knowledge about MIPS or RISC-V ISA labels Sep 23, 2017
@pavelkryukov pavelkryukov mentioned this issue Nov 3, 2017
Closed
@pavelkryukov
Copy link
Member Author

@col14m Hope you are well. Do you have any news regarding CMake?

@pavelkryukov
Copy link
Member Author

@col14m You are working for a month here, it would be nice if you shared some code at some branch. Actually I think we may keep both CMake and Makefile for some time.

@pavelkryukov pavelkryukov added infrastructure Improves build/CI infrastructure. and removed code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. labels Nov 16, 2017
@pavelkryukov
Copy link
Member Author

@col14m Any news, any updates?

@SoshinK SoshinK self-assigned this Dec 6, 2017
@pavelkryukov
Copy link
Member Author

@SoshinK The only one week is left before deadline. Do you estimate to have everything working beforehand?

@SoshinK SoshinK self-assigned this Mar 1, 2018
@SoshinK
Copy link
Contributor

SoshinK commented Mar 1, 2018

Good day(night?), Pavel. You probably thought that I gave up. In fact, I am still in. By that moment, I made Cmake for simulator(and a short buildscript for fast launch). But I have some problems with unit test for infra/config and with clang-tidy(It says 'stddef.h' not found). What should I do? Here solution(or should I make a pull request?): https://github.com/SoshinK/mipt-mips

@pavelkryukov
Copy link
Member Author

That's great!

Please merge with the latest version and integrate CMake to Travis. Then do a pull request so I can see output.

@pavelkryukov
Copy link
Member Author

Please open a pull request so I can comment your code

@SoshinK
Copy link
Contributor

SoshinK commented Mar 2, 2018

I still didnt cope with travis.yml

@pavelkryukov
Copy link
Member Author

The page: https://github.com/MIPT-ILab/mipt-mips/wiki/cmake

@pavelkryukov pavelkryukov added 5 Same as 4, but requires good understanding of CPU microarchitecture. and removed 3 Features of medium complexity or infrastructure enhancements labels Mar 9, 2018
@SoshinK
Copy link
Contributor

SoshinK commented Mar 12, 2018

I havent finished wiki about CMake yet

@SoshinK
Copy link
Contributor

SoshinK commented Mar 12, 2018 •
edited
Loading

There is the first part https://github.com/MIPT-ILab/mipt-mips/wiki/CMake

@pavelkryukov
Copy link
Member Author

pavelkryukov commented Mar 12, 2018 •
edited
Loading

OK, looks good. I'll make some fixes (spelling, grammar etc.) if needed.

Could you please add a section "Further Reading" to list additional sources of information (e.g. the one you used)?

@pavelkryukov
Copy link
Member Author

@SoshinK What about README changes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SoshinK SoshinK

Labels
5 Same as 4, but requires good understanding of CPU microarchitecture. infrastructure Improves build/CI infrastructure. S1 — ISA To solve the issue, you need knowledge about MIPS or RISC-V ISA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pavelkryukov @col14m @SoshinK