Wraps for open and write to file #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please provide more meaningful name for your pull request? |
pavelkryukov
suggested changes
Oct 21, 2019
pavelkryukov
suggested changes
Oct 21, 2019
| } | ||
|
|
||
| static uint64 open_file(System* sys, uint64 filename_ptr, uint64 flags) | ||
| { |
There was a problem hiding this comment.
Should these functions be members of System class?
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 90 90
Lines 3004 3004
=======================================
Hits 2993 2993
Misses 11 11Continue to review full report at Codecov.
|
pavelkryukov
suggested changes
Oct 22, 2019
Wraps for open, close, write and read that return a Trap. Tests for opening and writing to file were separated from big I/O file test.
pavelkryukov
suggested changes
Oct 24, 2019
pavelkryukov
approved these changes
Oct 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096