Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Transfer submission UI based on stakeholder feedback #687

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Apr 8, 2021

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@matt-bernhardt matt-bernhardt marked this pull request as draft April 8, 2021 16:12
@mitlib mitlib temporarily deployed to thesis-submit-pr-687 April 8, 2021 16:12 Inactive
@coveralls
Copy link

coveralls commented Apr 8, 2021

Coverage Status

Coverage increased (+0.006%) to 94.476% when pulling d93c85b on etd-258-stakeholder-feedback into 7dd139e on main.

@matt-bernhardt matt-bernhardt temporarily deployed to thesis-submit-pr-687 April 9, 2021 18:29 Inactive
@matt-bernhardt matt-bernhardt temporarily deployed to thesis-submit-pr-687 April 9, 2021 19:29 Inactive
@matt-bernhardt matt-bernhardt marked this pull request as ready for review April 9, 2021 19:39
@matt-bernhardt matt-bernhardt requested review from jazairi and JPrevost and removed request for jazairi April 9, 2021 19:40
@JPrevost JPrevost self-assigned this Apr 9, 2021
** Why are these changes being introduced:

* Internal stakeholders suggested a variety of changes to the transfer
  form which submitters will be testing next week.

** Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/ETD-258

** How does this address that need:

This makes the requested changes to the transfer form. Specific
changes are listed in the Jira ticket, but they boil down to:

* Changing the graduation year field to match the UI used on the thesis
  form.
* Implementing a confirmation page to give certain feedback to the
  submitter upon receipt of their files.
* Confirming that submitters will only see departments for which they
  are authorized.
* Wording and spacing changes around the form.
* Automated tests for form behavior and confirmation page.

** Document any side effects to this change:

None
@matt-bernhardt matt-bernhardt force-pushed the etd-258-stakeholder-feedback branch from f2fa91d to d93c85b Compare April 9, 2021 21:08
@matt-bernhardt matt-bernhardt temporarily deployed to thesis-submit-pr-687 April 9, 2021 21:09 Inactive
@matt-bernhardt matt-bernhardt merged commit a0a1e72 into main Apr 12, 2021
@matt-bernhardt matt-bernhardt deleted the etd-258-stakeholder-feedback branch April 12, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants