First part of Transfer processing #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
force-pushed
the
etd-276-transfer-processing-1
branch
from
00d56d5 to
f0d6a9a
Compare
matt-bernhardt
force-pushed
the
etd-276-transfer-processing-1
branch
from
f0d6a9a to
27f9060
Compare
matt-bernhardt
force-pushed
the
etd-276-transfer-processing-1
branch
from
2e1120a to
24d2a1a
Compare
JPrevost
approved these changes
May 3, 2021
| <script src="https://cdn.datatables.net/1.10.24/js/jquery.dataTables.min.js"></script> | ||
| <% end %> | ||
|
|
||
| <link href="https://cdn.datatables.net/1.10.24/css/jquery.dataTables.min.css" rel="stylesheet"> |
There was a problem hiding this comment.
I wonder if our theme gem should allow <% content_for :additional_css do %> to better handle this use case?
(No action needed, just thinking out loud).
There was a problem hiding this comment.
I was on the point of asking why I couldn't find a layout in this app - didn't think to ask about the theme gem. Yes, I think that would be a good feature to add for a use case like this.
(I don't think that blocks this merging, though right? We can do that via maintenance?)
app/views/transfer/_empty.html.erb
Outdated
| @@ -0,0 +1,3 @@ | |||
| <tr class="empty"> | |||
| <td colspan="6">There were no transfers matching your parameters. | |||
There was a problem hiding this comment.
smacks head D'oh! I'm going to push something to fix this.
JPrevost
approved these changes
May 3, 2021
** Why are these changes being introduced: * The first step of the Transfer processing workflow is to allow staff to identify which Transfer they want to process (out of all available) and get to the page that will allow them to process the submitted files. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-276 ** How does this address that need: * This defines a transfer selection screen (/transfer/select) where staff can see the list of available transfer records. This display can be filtered by graduation month (or by arbitrary user input). When the user clicks on any transfer in the list, they are taken to the (blank) detail page for that transfer. Future work will further develop that interface. * This PR also includes relevant tests for the navigation, the new path, and the existing ability model. ** Document any side effects to this change: * Part of the UI for this transfer selection screen is enabled by a jQuery plugin, DataTables. This plugin, while very useful out of the box, does increase our reliance on the jQuery ecosystem. A future discussion in EngX may lead to us needing to re-develop this screen using either Vue or native Javascript.
matt-bernhardt
force-pushed
the
etd-276-transfer-processing-1
branch
from
cbd14df to
54d382e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first few steps of the Transfer Processing workflow:
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO