Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading an attribute from a class instead of calling a method? #72

Open
csala opened this issue Oct 12, 2018 · 0 comments
Open
Labels
approved The issue is approved and work can be started new feature
Milestone

Comments

@csala
Copy link
Contributor

csala commented Oct 12, 2018

This is a discussion issue as a followup #71

Should we natively support returning a class attribute value (or multiple) instead of calling a method of the class during the produce phase?

This could be simple achieved at the JSON level by simply not specifying the method key.

Then, we would have:

    "produce": {
        "output": [
            {
                "name": "feature_weights",
                "attribute": "feature_importances_"   # This would be optional, to be used only if the used name does not match the attribute name.
                "type": "list"
            }
        ]
    }
@csala csala added the approved The issue is approved and work can be started label Dec 5, 2019
@csala csala added this to the 0.4.0 milestone Dec 5, 2019
@sarahmish sarahmish modified the milestones: 0.4.1, 0.5.0, 0.4.2 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The issue is approved and work can be started new feature
Projects
None yet
Development

No branches or pull requests

2 participants