Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve featuretools.dfs primitive #127

Closed
csala opened this issue Mar 6, 2019 · 0 comments
Closed

Improve featuretools.dfs primitive #127

csala opened this issue Mar 6, 2019 · 0 comments
Assignees
@csala
Labels
approved The issue is approved and someone can start working on it new feature A new feature is being requested
Milestone
0.1.7

Comments

@csala
Copy link
Contributor

csala commented Mar 6, 2019

  • MLPrimitives version: 0.1.6

Description

Several improvements can be done to the current featuretools.dfs primitive:

  • Remove the need to have X inside the entityset, using X as the cutoff time and index source instead of the target_entity
  • Add agg_primitives and tras_primitives arguments
  • Make X the default target_entity only when X is being used alone.
  • Accept target_entity, time_index and index as instance arguments.
  • Default to copy=True
@csala csala added new feature A new feature is being requested approved The issue is approved and someone can start working on it labels Mar 6, 2019
@csala csala self-assigned this Mar 6, 2019
@csala csala mentioned this issue Mar 6, 2019
Merged
@csala csala closed this as completed in #128 Mar 7, 2019
@csala csala added this to the 0.1.7 milestone Mar 7, 2019
@csala csala mentioned this issue Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csala csala

Labels
approved The issue is approved and someone can start working on it new feature A new feature is being requested
Projects
None yet
Milestone
0.1.7
Development

No branches or pull requests
1 participant
@csala