Major refactor with breaking changes #97
MLFlexer
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello everyone!
I have decided to do an extensive refactor of the
init.lua
file as it had become bloated with a lot of different logic for file i/o, state management, encryption etc.There will be breaking changes and before I just merge it to main, I would like to hear some feedback from the community, if there is any, if not, then I'll just merge in a couple of days 😄
I'm doing the refactor as it will be good for future development and contributers to seperate the logic into smaller digestible chunks contained within their own files.
I have added a PR which has the first draft to this refactor and it comes with a lot of breaking changes as it moved functions and events into sub-modules or scopes, instead of being in the global module/scope.
These changes in the modules/scope means that you have to prefix the changed functions/events with the module/scope which now contains it. You should be able to run a simple search and replace to automatically change these in your config, as to not be too burdensome users. However I would love to get some feedback reguarding the changes in the scope/modules.
The philosophy I have reguarding events is that the naming should be
resurrect.<name_of_module>.<name_of_function>.<event_name>
. This makes it easy for me and other contributers to add new events without emitting events which others might have listeners on.The changes from the PR #96 is as follows:
Moved fuzzy finder into
fuzzy_loader.lua
, encryption logic intoencryption.lua
and reading/writing files intofile_io.lua
and lastly state management intostate_manager.lua
. This does however come with breaking changes.BREAKING CHANGES:
Functions
Functions have been placed into other files which changes the scope, as such they will be renamed with the module/scope as prefix:
Emits
Emitters have also changed scope and have been renamed appropriately
To fix config on linux, you can run the following in your wezterm config directory:
Beta Was this translation helpful? Give feedback.
All reactions