New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use pathlib and subprocess; refactor other aspects #166

Merged

wpbonelli merged 1 commit into MODFLOW-USGS:develop from mwtoews:refactor-pathlib-subprocess

Dec 9, 2024

Collaborator

mwtoews commented Dec 9, 2024

There are several refactors combined in this PR:

Use pathlib more consistently (also enforced with Ruff's PTH rule (except for modflow_devtools/zip.py)
Refactor some aspects of subprocess.run() in meson_build() to not use shell=True. Also, run meson compile ... before meson install ...
Apply some automated fixes from Ruff rules C4, RUF and UP.
Fix missing parameter in test_fixtures.py::test_keep_function_scoped_tmpdir (found via Ruff's ARG rule)


          refactor: use pathlib and subprocess; refactor other aspects

dc0eaf5

mwtoews force-pushed the refactor-pathlib-subprocess branch from b979ebb to dc0eaf5 Compare

December 9, 2024 10:11

wpbonelli approved these changes

View reviewed changes

wpbonelli merged commit 438847c into MODFLOW-USGS:develop

18 checks passed

mwtoews deleted the refactor-pathlib-subprocess branch

December 9, 2024 16:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet