You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prior to cmake (#2689), the two git submodules for test data are stored at testing/binaries/data and testing/scripts/data. The run_tests script would (if necessary) pull the data from the corresponding repo, and for each test, it would change the working directory to that location; this makes filesystem paths within the test scripts as simple as possible, though results in pollution with temporary files if one is not careful.
Following #2689, it seems that despite the execution of tests now being done from inside a cmake build directory using the ctest command, it is nevertheless the case that the working directory in from which each test is executed is still testing/*/data; that is, back with the source data and not exclusively within the build directory.
IMO it would be more appropriate if, every time cmake is run in build mode, provided the relevant configuration flag was specified to enable tests in the destination build directory, the versions of the two submodules pointed to in the source code were downloaded into the testing/ subdirectory of the cmake build directory.
(We could also discuss whether it would be appropriate to merge these into a single repository; since in cmake-land I think it would be expected that, if tests are enabled for any given build directory, it should be possible to run those tests after build time without any further modification of the build directory contents, which means it would have to download all data from both repositories, regardless of what tests one might be intending to run.
Unless we had separate configuration environment variable flags for enabling unit tests / binary tests / script tests, I suppose... but I don't think it'd be worth the effort myself)
The text was updated successfully, but these errors were encountered:
Prior to
cmake
(#2689), the two git submodules for test data are stored attesting/binaries/data
andtesting/scripts/data
. Therun_tests
script would (if necessary) pull the data from the corresponding repo, and for each test, it would change the working directory to that location; this makes filesystem paths within the test scripts as simple as possible, though results in pollution with temporary files if one is not careful.Following #2689, it seems that despite the execution of tests now being done from inside a
cmake
build directory using thectest
command, it is nevertheless the case that the working directory in from which each test is executed is stilltesting/*/data
; that is, back with the source data and not exclusively within the build directory.IMO it would be more appropriate if, every time
cmake
is run in build mode, provided the relevant configuration flag was specified to enable tests in the destination build directory, the versions of the two submodules pointed to in the source code were downloaded into thetesting/
subdirectory of thecmake
build directory.(We could also discuss whether it would be appropriate to merge these into a single repository; since in
cmake
-land I think it would be expected that, if tests are enabled for any given build directory, it should be possible to run those tests after build time without any further modification of the build directory contents, which means it would have to download all data from both repositories, regardless of what tests one might be intending to run.Unless we had separate configuration environment variable flags for enabling unit tests / binary tests / script tests, I suppose... but I don't think it'd be worth the effort myself)
The text was updated successfully, but these errors were encountered: