Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with the plotting function now that ggsurvfit is on CRAN? #81

Closed
ddsjoberg opened this issue Sep 14, 2022 · 0 comments · Fixed by #82
Closed

What to do with the plotting function now that ggsurvfit is on CRAN? #81

ddsjoberg opened this issue Sep 14, 2022 · 0 comments · Fixed by #82

Comments

@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Sep 14, 2022

  • ggsurvfit has far better visualizations that what we had added to the pkg previously.
  • should we keep what we've created and just highlight ggsurvfit?
  • should we deprecate the old functions in favor of ggsurvfit?
  • should we re-export the ggsurvfit functions?

@tengfei-emory thoughts? we can discuss at the hackathon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant