Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reveal.js framework #274

Open
Lachlan-Mayne opened this issue Nov 21, 2023 · 1 comment · May be fixed by #307
Open

Update reveal.js framework #274

Lachlan-Mayne opened this issue Nov 21, 2023 · 1 comment · May be fixed by #307
Labels
enhancement New feature or request

Comments

@Lachlan-Mayne
Copy link

Is your feature request related to a problem? Please describe.
No issues, simply version of reveal.js in advanced slides is behind current reveal.js published version

Describe the solution you'd like
A clear and concise description of what you want to happen.
It'd be great to either a) learn how to manually change the reveal.js version used within your obsidian plugin, or b) get the plugin updated to support reveal.js 5.0.0, including features such as vertical slides

Describe alternatives you've considered
Learning how to update the plugin myself, minor background in python, no javascript experience
@Lachlan-Mayne Lachlan-Mayne added the enhancement New feature or request label Nov 21, 2023
@bcardiff
Copy link

I wanted to use https://revealjs.com/scroll-view/ feature but is only available since reveal 5.0.0.

The breaking changes in 5.0 does not seem to be problematic https://github.com/hakimel/reveal.js/releases/tag/5.0.0

Are there any fragile parts of the codebase that would require special attention when bumping the reveal version? From the version history there hasn't been any major version bump ever.

@bcardiff bcardiff linked a pull request Jun 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump reveal.js to 5.1.0, add support for scroll view bcardiff/obsidian-advanced-slides
2 participants
@bcardiff @Lachlan-Mayne