Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

feat(statistiques): ajoute le graph des stocks de concessions granulats marins #645

Merged
merged 1 commit into from
Feb 10, 2021
Merged

feat(statistiques): ajoute le graph des stocks de concessions granulats marins #645

merged 1 commit into from
Feb 10, 2021

Conversation

NeoBahamut
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #645 (50a365a) into master (6521622) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   98.94%   98.97%   +0.03%     
==========================================
  Files          73       74       +1     
  Lines        1802     1861      +59     
  Branches      370      382      +12     
==========================================
+ Hits         1783     1842      +59     
  Misses         19       19              
Impacted Files Coverage Δ
src/business/processes/titres-ids-update.ts 100.00% <0.00%> (ø)
...rc/business/rules/titre-activite-statut-id-find.ts 100.00% <0.00%> (ø)
...c/business/utils/titre-demarches-etapes-rebuild.ts 100.00% <0.00%> (ø)
...siness/processes/titres-props-etapes-ids-update.ts 100.00% <0.00%> (ø)
...ss/processes/titres-activites-statut-ids-update.ts 100.00% <0.00%> (ø)
src/database/models/_format/titre-contenu.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6521622...50a365a. Read the comment docs.

@NeoBahamut
Copy link
Contributor Author

)
.reduce(
(acc: { quantite: number; surface: number }, concession) => {
if (!concession) return acc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ne peut pas le mettre dans le filter juste au dessus ? 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai pas compris tes 2 commentaires Vincent

if (!concession) return acc

acc.quantite++
acc.surface += concession.surfaceEtape?.surface
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mettre aussi la vérification sur surfaceEtape?.surface dans le filter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

et cette condition ?  On peut la mettre dans le filter aussi stp ? @NeoBahamut

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut pas car il faut tout de même incrémenter la quantité 😅
Je merge !

@NeoBahamut NeoBahamut requested a review from vmaubert February 10, 2021 13:41
@vmaubert vmaubert merged commit 684636e into MTES-MCT:master Feb 10, 2021
@NeoBahamut NeoBahamut deleted the feat-statistiques-stock-concession-GM branch February 11, 2021 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants