-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can this be used with phpredis or is Predis required? #16
Comments
But I don't have a strong preference for Predis over anything else. I guess I can add a small abstraction layer to be compatible with both |
Yes I agree it would open this project up to a wider audience. Many PHP developers just assume (without understanding the network latency impact on real-world performance) that the phpredis C library is better performance than the Predis library. Rightly or wrongly, when someone chooses Redis, it's not a surprise that they are seeking maximum performance. I saw an abstraction layer approach here which might be suitable. I just assumed the parsing of redisearch results would be the difficult part - given the varying nature of command responses from redis. Perhaps there is already a solution for this...? |
I just open the PR #17 to allow other solution for connecting to Redis. For the |
@anthonymf I release the version Thanks again for the idea, it force me to refactor some part and rethink a bit how it was working. |
Nice work! I can see how you've widened the appeal and it makes this library the most attractive for PHP & redisearch. |
The phpredis library is known to be lot faster than Predis.
Does this package really need Predis?
The text was updated successfully, but these errors were encountered: