Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 support #13

Closed
zener05 opened this issue Feb 26, 2021 · 5 comments · Fixed by #14
Closed

PHP8 support #13

zener05 opened this issue Feb 26, 2021 · 5 comments · Fixed by #14

Comments

@zener05
Copy link

zener05 commented Feb 26, 2021

Hi Machy8 👋

We would like to upgrade our app to PHP8 but there are some deprecated messages because of this package.

Could you add support for PHP8, please?
@Machy8
Copy link
Owner

Machy8 commented Mar 1, 2021

I will look into it.

@Machy8 Machy8 linked a pull request Mar 7, 2021 that will close this issue
Migrate to PHP8 #14
Merged
@Machy8
Copy link
Owner

Machy8 commented Mar 7, 2021

@zener05 Could you please let me know if changes in this pull requests (branch) works in your project? Thanks #14

@zener05
Copy link
Author

zener05 commented Mar 9, 2021

It seems to be working well 👍 Thank you!

@Machy8
Copy link
Owner

Machy8 commented Mar 13, 2021

@zener05 I have released a new version https://packagist.org/packages/machy8/webloader#v2.0.0. So check it out. Please let me know if you encounter any other issues.

@zener05
Copy link
Author

zener05 commented Mar 14, 2021

We haven't upgraded to PHP8 yet so I can't give you proper feedback. But as I wrote it seemed to be working well during my tests.

I would let you know if there were any problems in future. Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to PHP8 Machy8/webloader
2 participants
@zener05 @Machy8