You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like the problem is the fact that browserify is converting module ids to numerical indexes, so the require('Label.jsx') call fails. I've also tried using --fullPaths, but that also fails because it would expect an absolute path to Label.jsx, not just Label.jsx.
The hot reload still seems to work, but I wonder if there's anything that could be done to fix this?
The text was updated successfully, but these errors were encountered:
The current
example/
uses an old version ofreact-hot-loader
which silently swallowsrequire
errors:https://github.com/gaearon/react-hot-loader/blob/62f9ccdd076b26302dae077c23de3dd6812ebd97/src/hot.dev.js#L27-L31
The latest version of
react-hot-loader
always logs require errors:https://github.com/gaearon/react-hot-loader/blob/3fadc05783f2aa534372dbe6846b1a379ed76ebd/src/hot.dev.js#L86-L93
Steps to reproduce:
https://github.com/Macil/browserify-hmr cd browserify-hmr/example npm install npm install react-hot-loader@latest npm start
After modifying
Label.jsx
, the component refreshes in the browser, but an error is present in browser console:It looks like the problem is the fact that browserify is converting module ids to numerical indexes, so the
require('Label.jsx')
call fails. I've also tried using--fullPaths
, but that also fails because it would expect an absolute path toLabel.jsx
, not justLabel.jsx
.The hot reload still seems to work, but I wonder if there's anything that could be done to fix this?
The text was updated successfully, but these errors were encountered: