This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Null check on currentDevice #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
suggested changes
Nov 4, 2016
| @@ -107,10 +107,14 @@ void NotifyAsync(uv_work_t* req) { | |||
| void NotifyFinished(uv_work_t* req) { | |||
| if (isRunning) { | |||
| if(isAdded) { | |||
| NotifyAdded(currentDevice); | |||
| if (currentDevice != NULL) { | |||
| } | ||
| else { | ||
| NotifyRemoved(currentDevice); | ||
| if (currentDevice != NULL) { |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "usb-detection", | |||
| "version": "1.4.0", | |||
| "version": "1.4.1", | |||
There was a problem hiding this comment.
Let's not bump the version in the PR. We can start a release once this gets into master.
|
I made those changes to the other platforms. It would be a smaller change if we just put the check in detection.cpp. VS Code cleaned up a bunch of spaces at the end of lines. Let me know if you want me to back those out. |
|
I think this is ready to go. I have tested it on Mac and Windows. I don't have a linux env to test it on. |
|
@reidmweber Sorry for the delay. My timeline is to review this again over the upcoming weekend. Keep with the pings if it slips. |
|
I have merged the changes via these two PRs Thanks for the contribution 😀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using this in an electron app running in Windows. We were getting a crash about 5-10 minutes into launching the app. We've only been able to reproduce it on one PC. Somehow NotifyRemoved in detection.cpp is getting called with a null device and causing a null ptr exception. The PC has a touchscreen that isn't working so it may be that the touchscreen device is continually connecting and disconnecting to create this scenario.
In any case, this change has fixed the crash for us.