Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up inheritance mess for integrations #151

Open
4 tasks
Tracked by #161
MaddyGuthridge opened this issue Nov 27, 2023 · 0 comments
Open
4 tasks
Tracked by #161

Clean up inheritance mess for integrations #151

MaddyGuthridge opened this issue Nov 27, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation framework Issues that affect the overal UCS framework integrations Issues that affect an integration
Milestone

Comments

@MaddyGuthridge
Copy link
Owner

MaddyGuthridge commented Nov 27, 2023

Currently, integrations are a mess - it's immensely difficult to get a solid mental model of them.

In order to address this, some major refactoring should be done:

  • Have the one Integration base class which all integrations inherit from
  • Simplify the interface such that integrations are the same for PluginIntegration, WindowIntegration and CoreIntegration
  • Move CoreIntegration's shouldBeActive classmethod to be part of the base class definition, and should probably be called isEnabled or something
  • Simplify the extension manager system to allow for integrations to be registered alongside their activity criteria (ie use a decorator that allows users to specify the conditions for its activity)
@MaddyGuthridge MaddyGuthridge added documentation Improvements or additions to documentation integrations Issues that affect an integration framework Issues that affect the overal UCS framework labels Nov 27, 2023
@MaddyGuthridge MaddyGuthridge added this to the UCS 2.0 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation framework Issues that affect the overal UCS framework integrations Issues that affect an integration
Projects
None yet
Development

No branches or pull requests

1 participant