(GH-3339) StrongName signed assembly? Hey, it's 2018...

Change scheme of FileVersion to MajorMinorPatchTag and AssemblyVersion to MajorMinorPatch Closes #3339
MahApps · Sep 25, 2018 · b9ab758 · b9ab758
1 parent f84afcf
commit b9ab758
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 3 deletions.
diff --git a/GitVersion.yml b/GitVersion.yml
@@ -1,4 +1,5 @@
-assembly-versioning-scheme: MajorMinorPatchTag
+assembly-versioning-scheme: MajorMinorPatch
+assembly-file-versioning-scheme: MajorMinorPatchTag
 mode: ContinuousDeployment
 next-version: 2.0.0
 branches:

diff --git a/src/MahApps.Metro/MahApps.Metro.csproj b/src/MahApps.Metro/MahApps.Metro.csproj
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project Sdk="MSBuild.Sdk.Extras">
     <!-- Project properties -->
     <PropertyGroup>
@@ -7,6 +7,13 @@
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
         <ExtrasDefaultPageExcludes>$(ExtrasDefaultPageExcludes);**\*.Template.xaml</ExtrasDefaultPageExcludes>
     </PropertyGroup>
+    <!-- Sign assembly -->
+    <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
+        <SignAssembly>True</SignAssembly>
+        <AssemblyOriginatorKeyFile>$(MSBuildProjectDirectory)\..\SharedKey.snk</AssemblyOriginatorKeyFile>
+        <DelaySign>false</DelaySign>
+        <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
+    </PropertyGroup>
     <ItemGroup>
         <Reference Include="System.ComponentModel.DataAnnotations" />
         <Reference Include="System.Configuration" />

diff --git a/src/SharedKey.snk b/src/SharedKey.snk
diff --git a/src/build.cake b/src/build.cake
@@ -139,6 +139,7 @@ Task("Zip-Demos")
 });
 
 Task("Unit-Tests")
+    .WithCriteria(() => !local)
     .Does(() =>
 {
     XUnit2(

diff --git a/src/paket.lock b/src/paket.lock
@@ -4,7 +4,7 @@ NUGET
     Caliburn.Micro (3.2)
       Caliburn.Micro.Core (3.2)
     Caliburn.Micro.Core (3.2)
-    ControlzEx (4.0.0-alpha0175)
+    ControlzEx (4.0.0-alpha0176)
     Costura.Fody (3.1.2)
       Fody (>= 3.2.4) - restriction: >= net46
     ExposedObject (1.2)