Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressDialog should have diffrent min/max values. [Request] #1702

Closed
Jyrka98 opened this issue Dec 11, 2014 · 4 comments
Closed

ProgressDialog should have diffrent min/max values. [Request] #1702

Jyrka98 opened this issue Dec 11, 2014 · 4 comments
Assignees
Milestone

Comments

@Jyrka98
Copy link

Jyrka98 commented Dec 11, 2014

Hello.
I recently tried using the ProgressDialog and found out it only accepts values from 0.0 to 1.0.
The progressbar should show more precise values. Would it be possible to change the min/max values? or instead add Maximum and Minimum properties?

@flagbug
Copy link
Member

flagbug commented Dec 11, 2014

You can just calculate the progress percentage from your values which should be basically the same

@Jyrka98
Copy link
Author

Jyrka98 commented Dec 13, 2014

Yes, i can do that. I'm just saying it would be better if it is more precise

@thoemmi
Copy link
Collaborator

thoemmi commented Dec 13, 2014

The progress value is of type double. I assume that's precise enough, isn't it?

@michaelmairegger
Copy link
Contributor

It would be easy to implement such a behaviour @Jyrka98 requested. Just add following lines to ProgressDialogController

public double Minimum
{
    get { return WrappedDialog.PART_ProgressBar.Minimum; }
    set { WrappedDialog.PART_ProgressBar.Minimum = value; }
}

public double Maximum
{
    get { return WrappedDialog.PART_ProgressBar.Maximum; }
    set { WrappedDialog.PART_ProgressBar.Maximum = value; }
}

and delete the line

WrappedDialog.PART_ProgressBar.Maximum = 1.0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants