Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox colors on dark theme arent good #3136

Closed
Symbai opened this issue Dec 31, 2017 · 5 comments · Fixed by #3534
Closed

Checkbox colors on dark theme arent good #3136

Symbai opened this issue Dec 31, 2017 · 5 comments · Fixed by #3534
Assignees
@punker76
Labels
Breaking Change
Milestone
2.0.0

Comments

@Symbai
Copy link

Symbai commented Dec 31, 2017 •
edited
Loading

Below is a screenshot of the demo showing the default white theme and dark puple. As you can see the checkbox on white theme is okay but on dark theme hardly seeable because the purple color is too dark. Same problem with lots of other colors on dark theme. I don't think this issue needs a sample as you can reproduce this in a second on the demo app.

theme

//edit: For some reasons I've noticed the color on checkboxes are different than the color used on other controls:

theme2
@Symbai Symbai changed the title Colors on dark theme arent good Checkbox colors on dark theme arent good Dec 31, 2017
@punker76
Copy link
Member

punker76 commented Jan 5, 2018

@Symbai Yes, the modern Win 10 checkbox and radiobox styles invert the brushes. I must agree it looks with some accent brushes not so good. But I think we can not do this in 1.6 cause it's a bigger visual breaking change.

2018-01-05_13h39_27
2018-01-05_13h39_33

/cc @thoemmi

@thoemmi
Copy link
Collaborator

thoemmi commented Jan 5, 2018

I agree with @punker76 . As far as I can see 1.6 is almost finished.

@punker76 punker76 added this to the 2.0.0 milestone Jan 5, 2018
@punker76 punker76 self-assigned this Jan 5, 2018
@amkuchta
Copy link
Contributor

amkuchta commented Jan 25, 2018 •
edited
Loading

@punker76 @Symbai @thoemmi this might also be a good time to adjust how the various accent colors are produced. Currently, it looks like the same color is utilized, but the alpha is adjusted to let the background bleed through. I think that a better way to handle this would be to utilize a tool like Coolors.co to define a base color, then get alternative shades for it.

It might also be a good time to move away from names like BlackBrush and WhiteBrush and to something along the lines of BaseBackgroundBrush and BaseForegroundBrush.

Again, just thoughts 😃

@amkuchta
Copy link
Contributor

I'm just going to leave this here...

UWP Color Design Guide

@Symbai Symbai closed this as completed Dec 6, 2018
@Symbai
Copy link
Author

Symbai commented Jan 11, 2019

Downloaded the latest demo but it looks like there hasn't been any progress on this?

@Symbai Symbai reopened this Jan 11, 2019
@timunie timunie mentioned this issue May 27, 2019
Closed
@timunie timunie mentioned this issue Jun 17, 2019
Merged
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) DoubleToGridLengthConverter is not necessary
762d7f5
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) DoubleToGridLengthConverter is not necessary
a408373
punker76 pushed a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@timunie @punker76
(MahAppsGH-3136) Introduce CheckBoxHelper
fabd465 
A CheckBoxHelper was introdiuced to allow different Glyphs for different Styles
punker76 pushed a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@timunie @punker76
(MahAppsGH-3136) Introduce new Windows 10 CheckBox Style
16f4cd5 
Introduced a new CheckBox Style that switches the colors for a better visibility, especially with a dark theme
punker76 pushed a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@timunie @punker76
(MahAppsGH-3136) Fixed GridLength for RightToLeft ContentDirection
cd7ee53
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) Adaptations to the new resource names
bf17228
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) DoubleToGridLengthConverter is not necessary
0ec5ed5
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) Fix CheckBox focus
190ff90 
Prevent focusing for inner ContentControls.
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) Use Win10 check glyph Xaml path data from "Segoe MDL…
58534b0 
…2 Assets"
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) Set Win10 BorderThickness to 2
b503e53
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) Xaml formating
01462e2
punker76 pushed a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@timunie @punker76
(MahAppsGH-3136) Introduce CheckBoxHelper
cf25bed 
A CheckBoxHelper was introdiuced to allow different Glyphs for different Styles
punker76 pushed a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@timunie @punker76
(MahAppsGH-3136) Introduce new Windows 10 CheckBox Style
e6886d4 
Introduced a new CheckBox Style that switches the colors for a better visibility, especially with a dark theme
punker76 pushed a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@timunie @punker76
(MahAppsGH-3136) Fixed GridLength for RightToLeft ContentDirection
f0c33d6
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) Adaptations to the new resource names
3df589f
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) DoubleToGridLengthConverter is not necessary
fe46593
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Sep 2, 2019
@punker76
(MahAppsGH-3136) Fix CheckBox focus
3476277 
Prevent focusing for inner ContentControls.
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 8, 2019
@punker76
(MahAppsGH-3136) Fix CheckBox focus
7b8305a 
Prevent focusing for inner ContentControls.
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 8, 2019
@punker76
(MahAppsGH-3136) Use Win10 check glyph Xaml path data from "Segoe MDL…
f4c7f12 
…2 Assets"
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 8, 2019
@punker76
(MahAppsGH-3136) Set Win10 BorderThickness to 2
731609b
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 8, 2019
@punker76
(MahAppsGH-3136) Xaml formating
cef2649
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 8, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
9deacf7 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 14, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
0e9c257 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 15, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
6b4a2a0 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 23, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
3e533db 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 29, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
b524281 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 2, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
77f4a5f 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 4, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
d5989f6 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 17, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
745e102 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 17, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
47a48ad 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 20, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
936c2ed 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 21, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
e2a8d22 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 28, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
31b96d1 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 28, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
64613ed 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Nov 30, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
5a747ff 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Dec 7, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
975c1ee 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Dec 12, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
7303ebf 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Dec 27, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
7aadd78 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Dec 28, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
bcf949e 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2

Code format
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Dec 29, 2019
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
9f8b442 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2

Code format


renaming
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Jan 5, 2020
@punker76
(MahAppsGH-3136) Introduce CheckBoxHelper and new Windows 10 CheckBox…
20c6878 
… Style

- A CheckBoxHelper was introduced to allow different Glyphs and Brushes for different Styles
- Introduced a new Windows 10 CheckBox Style that switches the colors for a better visibility, especially with a dark theme
	- Use Win10 check glyph Xaml path data from "Segoe MDL2 Assets"
	- Set Win10 BorderThickness to 2

Code format


renaming
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Jan 6, 2020
@punker76
(MahAppsGH-3136) Finalize Win10 CheckBox style
9ed11ae
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Jan 6, 2020
@punker76
(MahAppsGH-3136) Codacy/PR Quality Review
db4d750
@punker76 punker76 mentioned this issue Jan 6, 2020
Closed
punker76 added a commit that referenced this issue Jan 9, 2020
@punker76
(GH-3136) Fix new Win10 brushes based on Win10 SDK (10.0.18362.0, 1903)
bb3de1c
punker76 added a commit that referenced this issue Mar 1, 2020
@punker76
(GH-3136) Use all UWP named CheckBox brushes
16adeef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
Breaking Change
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

CheckBox Windows 10 Style timunie/MahApps.Metro
4 participants
@thoemmi @punker76 @amkuchta @Symbai