Click on Expander header support #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punker76
added a commit
that referenced
this pull request
Apr 12, 2014
Click on Expander header support
michaelmairegger
added a commit
to michaelmairegger/MahApps.Metro
that referenced
this pull request
Apr 14, 2014
|
There was introduced an optical bug which I try to solve Before this commit The XAML I use is as follows: <Grid Name="Grid">
<Grid.ColumnDefinitions>
<ColumnDefinition />
<ColumnDefinition Width="24" />
</Grid.ColumnDefinitions>
[...]
</Grid> |
|
Looks like I had to test it a little bit more... thanks! |
|
But my commit is untill now not complete. |
michaelmairegger
added a commit
to michaelmairegger/MahApps.Metro
that referenced
this pull request
Apr 23, 2014
Fix optical bug intruduced in MahApps#1291 (reverted from commit 7b9a60f)
|
@punker76 Can you undo this merge, because of the problem I have shown in the screenshots untill we have found a solution for the header problem? |
|
@xxMUROxx done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Expander control does not open when you click the header text, which is not the default behavior, and may be annoying.
I set the Header as the content of the ToggleButton that determines whether the Expander is open or not, which fixed the problem.