Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow showing title bar while showing dialog (Fixes #2109) #2534

Merged
merged 1 commit into from
Jun 4, 2016
Merged

Allow showing title bar while showing dialog (Fixes #2109) #2534

merged 1 commit into from
Jun 4, 2016

Conversation

Deadpikle
Copy link
Contributor

What changed?

Added ShowDialogsOverTitleBar property to MetroWindow to set whether dialogs show over (hide) the window's title bar or not. Defaults to true so that legacy applications are not affected.

Fixes #2109

@punker76 punker76 added this to the 1.3.0 milestone Jun 4, 2016
@punker76 punker76 merged commit 19da577 into MahApps:develop Jun 4, 2016
@punker76
Copy link
Member

punker76 commented Jun 4, 2016

👍 welcome to the contributors list!
I changed minor usage of the new property. It works now directly via Triggers.

@barishamil
Copy link

Title bar is there but close button doesn't close the window, any workarounds?

@punker76
Copy link
Member

@barishamil I don't know what's the problem for you. MahApps version? What did you do?

@barishamil
Copy link

barishamil commented Dec 20, 2017

@punker76
I set ShowDialogsOverTitleBar="False" on my MetroWindow
Then called this.ShowMetroDialogAsync(myDialog)
Dialog opens and doesn't overlay title bar as I wanted but I can't close the window with the close button on the title bar while dialog is visible
MahApps.Metro 1.5.0

@punker76
Copy link
Member

@barishamil Ah, sorry, it's already tracked #2882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants