-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic concept of glow window from GitHub project #347
Conversation
2. Toolbar - Add margin so that it looks similar to VS.
I am not seeing this on the demo app on my branch. Is there a reproducible sample that I can play around with? |
I just pulled down the branch and opened the MetroDemo application. |
Are you seeing the same in AccentColor Demo? Also, can you see if you are facing the same for the base project at https://github.com/Grabacr07/MetroLikeWindow |
|
All of the above are working fine for me. Not sure what is wrong. |
Do you think this has something to do with the OS or some configuration? I tried it in multiple machines and it seems to be working fine. |
I'm running Windows 8, no external monitor connected. Might it be related to that? Sent from my Windows Phone From: Chandramouleswaran Do you think this has something to do with the OS or some configuration? I tried it in multiple machines and it seems to be working fine. — |
I tried this in Windows 7 and Windows 8. Are you using remote desktop to connect to the machine? If that is the case, I can test it out. |
No From: Chandramouleswaran I tried this in Windows 7 and Windows 8. Are you using remote desktop to connect to the machine? If that is the case, I can test it out. — |
I am lost - what do you mean by no external monitor? |
Nothing fancy for the setup – just my W520 running Windows 8 From: Chandramouleswaran [mailto:notifications@github.com] I am lost - what do you mean by no external monitor? — |
Is this still a problem? Can you try it on a different machine and let me know? |
I only have one machine with me at the moment. Will try it again and see if I can spot the issue here. |
I'm still seeing the issue here - I'll try and capture a screencast when I get decent enough internet to download a screencast tool so you can see it in real-time. |
I am not sure if I have a solution for the issue because I can't see it :( |
Any luck getting this to run on another machine? |
This works fine for me. |
What's your setup? I'm puzzled as to why I feel like the odd man out here... From: AdditionalPylons This works fine for me. — |
I'm running windows 8 64 bit on a standard desktop computer. |
Here is a screencast of what I am seeing - http://www.youtube.com/watch?v=9vdjbEMYVyQ |
Says Video is private. |
Can you try it now? |
@shiftkey - Are you still seeing the issue? Did you try this on another PC? |
@chandramouleswaran i haven't been able to try it on another PC as I am trekking across the US right now. Let me test it again - I've got a screen capture tool installed so I can share what I'm seeing now as well. |
@chandramouleswaran Set your computer to 120 DPI, I bet you'll see it. http://www.sevenforums.com/tutorials/443-dpi-display-size-settings-change.html |
Yes - that seems to be the problem. Let me look into it. |
@chandramouleswaran I'll just leave this here: http://stackoverflow.com/questions/1918877/how-can-i-get-the-dpi-in-wpf/1918890#1918890 |
@xpaulbettsx - Thanks a lot, I was just looking at that post 👍 |
The issue is because of rounding from double to int in bigger DPIs - this is not very accurate. Optimized using Math.Ceiling for top and left as those are the only sides with this issue. |
Nice work ^_^ |
Thanks! |
Will this be merged? :) |
@chandramouleswaran i'd like to leave this one until after I've pushed out the next stable release. See #327 for the specifics |
Cool - sounds good. |
Rebased and merged in: 86cb261 Had to add the files into the NET45 project as well, which was not covered by the original PR. |
Added a new property for MetroWindow called the GlowBrushProperty. This can be set to a solid color brush which will be used for the drop shadow effect on the metro window.
Original idea was from https://github.com/Grabacr07/MetroLikeWindow