Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic concept of glow window from GitHub project #347

Closed
wants to merge 8 commits into from
Closed

Basic concept of glow window from GitHub project #347

wants to merge 8 commits into from

Conversation

chandramouleswaran
Copy link
Contributor

Added a new property for MetroWindow called the GlowBrushProperty. This can be set to a solid color brush which will be used for the drop shadow effect on the metro window.

Original idea was from https://github.com/Grabacr07/MetroLikeWindow

Glow

@shiftkey
Copy link

There's something off with the calculation of the glow window. See the attached screenshot:

image

The difference is greater the further the window is from the top-left corner, so it appears to be something that should be resolvable.

@chandramouleswaran
Copy link
Contributor Author

I am not seeing this on the demo app on my branch. Is there a reproducible sample that I can play around with?

@shiftkey
Copy link

I just pulled down the branch and opened the MetroDemo application.

@chandramouleswaran
Copy link
Contributor Author

Are you seeing the same in AccentColor Demo? Also, can you see if you are facing the same for the base project at https://github.com/Grabacr07/MetroLikeWindow

@shiftkey
Copy link

  • AccentColor - same issue
  • VS2012LikeWindow1 - position appears right, didn't test repositioning as window isn't draggable
  • VS2012LikeWindow2 - same issue

@chandramouleswaran
Copy link
Contributor Author

All of the above are working fine for me. Not sure what is wrong.

@chandramouleswaran
Copy link
Contributor Author

Do you think this has something to do with the OS or some configuration? I tried it in multiple machines and it seems to be working fine.

@shiftkey
Copy link

I'm running Windows 8, no external monitor connected. Might it be related to that?

Sent from my Windows Phone


From: Chandramouleswaran
Sent: 20/02/2013 08:45
To: MahApps/MahApps.Metro
Cc: Brendan Forster
Subject: Re: [MahApps.Metro] Basic concept of glow window from GitHub project (#347)

Do you think this has something to do with the OS or some configuration? I tried it in multiple machines and it seems to be working fine.


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-13842084.

@chandramouleswaran
Copy link
Contributor Author

I tried this in Windows 7 and Windows 8. Are you using remote desktop to connect to the machine? If that is the case, I can test it out.

@shiftkey
Copy link

No


From: Chandramouleswaran
Sent: 20/02/2013 09:19
To: MahApps/MahApps.Metro
Cc: Brendan Forster
Subject: Re: [MahApps.Metro] Basic concept of glow window from GitHub project (#347)

I tried this in Windows 7 and Windows 8. Are you using remote desktop to connect to the machine? If that is the case, I can test it out.


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-13844162.

@chandramouleswaran
Copy link
Contributor Author

I am lost - what do you mean by no external monitor?

@shiftkey
Copy link

Nothing fancy for the setup – just my W520 running Windows 8

From: Chandramouleswaran [mailto:notifications@github.com]
Sent: Wednesday, 20 February 2013 2:43 PM
To: MahApps/MahApps.Metro
Cc: Brendan Forster
Subject: Re: [MahApps.Metro] Basic concept of glow window from GitHub project (#347)

I am lost - what do you mean by no external monitor?


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-13861655.

@chandramouleswaran
Copy link
Contributor Author

Is this still a problem? Can you try it on a different machine and let me know?

@shiftkey
Copy link

shiftkey commented Mar 3, 2013

I only have one machine with me at the moment. Will try it again and see if I can spot the issue here.

@shiftkey
Copy link

shiftkey commented Mar 3, 2013

I'm still seeing the issue here - I'll try and capture a screencast when I get decent enough internet to download a screencast tool so you can see it in real-time.

@chandramouleswaran
Copy link
Contributor Author

I am not sure if I have a solution for the issue because I can't see it :(

@chandramouleswaran
Copy link
Contributor Author

Any luck getting this to run on another machine?

@davidzech
Copy link
Contributor

This works fine for me.

@shiftkey
Copy link

shiftkey commented Mar 8, 2013

What's your setup? I'm puzzled as to why I feel like the odd man out here...


From: AdditionalPylons
Sent: 07/03/2013 18:05
To: MahApps/MahApps.Metro
Cc: Brendan Forster
Subject: Re: [MahApps.Metro] Basic concept of glow window from GitHub project (#347)

This works fine for me.


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-14594941.

@davidzech
Copy link
Contributor

I'm running windows 8 64 bit on a standard desktop computer.

@chandramouleswaran
Copy link
Contributor Author

Here is a screencast of what I am seeing - http://www.youtube.com/watch?v=9vdjbEMYVyQ

@davidzech
Copy link
Contributor

Says Video is private.

@chandramouleswaran
Copy link
Contributor Author

Can you try it now?

@chandramouleswaran
Copy link
Contributor Author

@shiftkey - Are you still seeing the issue? Did you try this on another PC?

@shiftkey
Copy link

@chandramouleswaran i haven't been able to try it on another PC as I am trekking across the US right now.

Let me test it again - I've got a screen capture tool installed so I can share what I'm seeing now as well.

@shiftkey
Copy link

@anaisbetts
Copy link

@chandramouleswaran Set your computer to 120 DPI, I bet you'll see it. http://www.sevenforums.com/tutorials/443-dpi-display-size-settings-change.html

@shiftkey
Copy link

@xpaulbettsx FWIW I run at 125% magnification (which is 120 DPI when you follow those links through to their logical conclusion)

image

@chandramouleswaran
Copy link
Contributor Author

Yes - that seems to be the problem. Let me look into it.

@anaisbetts
Copy link

@chandramouleswaran
Copy link
Contributor Author

@xpaulbettsx - Thanks a lot, I was just looking at that post 👍
@shiftkey - Can you check now?

@shiftkey
Copy link

It's so close - just seeing some whitespace around the edges now.

image

Perf looks good from my testing, will dig deeper tomorrow.

@chandramouleswaran
Copy link
Contributor Author

The issue is because of rounding from double to int in bigger DPIs - this is not very accurate. Optimized using Math.Ceiling for top and left as those are the only sides with this issue.

@davidzech
Copy link
Contributor

Nice work ^_^

@chandramouleswaran
Copy link
Contributor Author

Thanks!

@chandramouleswaran
Copy link
Contributor Author

Will this be merged? :)

@shiftkey
Copy link

@chandramouleswaran i'd like to leave this one until after I've pushed out the next stable release. See #327 for the specifics

@chandramouleswaran
Copy link
Contributor Author

Cool - sounds good.

@shiftkey
Copy link

Rebased and merged in: 86cb261

Had to add the files into the NET45 project as well, which was not covered by the original PR.

@shiftkey shiftkey closed this Apr 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants