-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-3746) Fix Date and Time selection and other improvements for DateTimePicker #3775
Conversation
4c4260c
to
6e648b7
Compare
6e648b7
to
b70a950
Compare
@punker76 can we change Have a great day |
d6e81f8
to
fe89f21
Compare
@timunie You can use the RoutedPropertyChangedEventHandler and RoutedPropertyChangedEventArgs which are generic classes. I removed the TimePickerBaseSelectionChangedEventArgs because we don't need them. |
Thank you for the info. I wil use this instead |
504a50a
to
4771714
Compare
…icker - if the Time is selected before a Date is selected use DateTime.Today instead of DateTime.Min - If a new Value is selected from the Calendar we use the already Selected time. - Implemented a new private `bool` to disable changing the time.
…rmark, Fix wrong focus for popup content
…s for the PopUp content
…ntrols.TimePickerBase' as owner
…se RoutedPropertyChangedEventHandler and RoutedPropertyChangedEventArgs
…reaks time selection and more...
4771714
to
966f01b
Compare
Describe the changes you have made to improve this project
Unit test
DateTimePickerTests
Additional context
There is one issue left where I have no idea how to solve this: If the user inserts a newDateTime
manually where the time is00:00:00
the time might get overridden with the last used time. I think this case is rather rare, but should be considered anyway.Closed Issues
Closes #3746