Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-3840) DataGrid auto generated column styles #3841

Merged
merged 8 commits into from
Jun 12, 2020

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Jun 7, 2020

Describe the changes you have made to improve this project

This PR resolves the need to explicitly specify column styles. Currently if no styles is set and the columns are not autogenerated then the columns will use the default WPF styles.

  • Fix finally "Cannot find source for binding with reference..." errors
  • Introduce new DataGridColumnStylesHelperExtension to enable auto generated column styles. It implements a IDataGridColumnStylesHelper interface to allow using custom defined helpers.
  • Add new style MahApps.Styles.TextBlock.DataGrid
  • Add AutoGeneratedComboBoxColumnStyle and AutoGeneratedComboBoxColumnEditingStyle attached properties
  • Add new style MahApps.Styles.ComboBox.DataGrid
  • Add AutoGeneratedNumericUpDownColumnStyle and AutoGeneratedNumericUpDownColumnEditingStyle attached properties
  • Use real default styles for NumericUpDownColumn (without looking for a base style)
  • Fix style key MahApps.Styles.NumericUpDown.DataGridColumn to MahApps.Styles.NumericUpDown.DataGrid
  • Fix style key MahApps.Styles.NumericUpDown.DataGridColumnEditing to MahApps.Styles.NumericUpDown.DataGrid.Editing
  • Add new default style for Hyperlink MahApps.Styles.Hyperlink
  • Add AutoGeneratedHyperlinkColumnStyle and AutoGeneratedHyperlinkColumnEditingStyle attached properties
  • Add new style MahApps.Styles.Hyperlink.DataGrid

Closed Issues

Closes #3840

@punker76 punker76 added this to the 2.0.2 milestone Jun 7, 2020
Introduce new DataGridColumnStylesHelperExtension to enable auto generated column styles. It implements a IDataGridColumnStylesHelper interface to allow using custom defined helpers.

- Adds new style MahApps.Styles.TextBlock.DataGrid
- Add AutoGeneratedComboBoxColumnStyle and AutoGeneratedComboBoxColumnEditingStyle attached properties
- Add new style MahApps.Styles.ComboBox.DataGrid
- Add AutoGeneratedNumericUpDownColumnStyle and AutoGeneratedNumericUpDownColumnEditingStyle attached properties
- Use real default styles (without looking for a base style)
- Fix style key `MahApps.Styles.NumericUpDown.DataGridColumn` to `MahApps.Styles.NumericUpDown.DataGrid`
- Fix style key `MahApps.Styles.NumericUpDown.DataGridColumnEditing` to `MahApps.Styles.NumericUpDown.DataGrid.Editing`
@punker76 punker76 force-pushed the fix/GH-3840-DataGrid-AutoGeneratedColumnStyles branch from b7b8495 to 8aabe07 Compare June 9, 2020 08:56
- Add new default style for Hyperlink MahApps.Styles.Hyperlink
- Add AutoGeneratedHyperlinkColumnStyle and AutoGeneratedHyperlinkColumnEditingStyle attached properties
- Add new style MahApps.Styles.Hyperlink.DataGrid
@punker76 punker76 merged commit a5332cf into develop Jun 12, 2020
@punker76 punker76 deleted the fix/GH-3840-DataGrid-AutoGeneratedColumnStyles branch June 12, 2020 09:27
@punker76 punker76 modified the milestones: 2.0.2, 2.1.0 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Checkboxes using Dark theme within DataGrid column appear unchecked (Server 2012 R2)
1 participant