Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-3839) Allow setting AutomationProperties for HamburgerMenuItem #3856

Merged
merged 5 commits into from
Jun 18, 2020

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Jun 16, 2020

Describe the changes you have made to improve this project

Allow setting the AutomationProperties for HamburgerMenuItem

  • AutomationProperties.HelpText
  • AutomationProperties.LabeledBy
  • AutomationProperties.Name

If Name or HelpText are empty the Label and ToolTip properties will be used.

Add HamburgerMenu button properties to set AutomationProperties

  • New HamburgerButtonName property to set AutomationProperties.NameProperty
  • New HamburgerButtonHelpText property to set AutomationProperties.HelpTextProperty

Unit test

Additional context

Closed Issues

Closes #3839

@punker76 punker76 modified the milestones: 2.0.2, 2.1.0 Jun 16, 2020
@punker76 punker76 force-pushed the fix/GH-3839-HamburgerMenu-AutomationProperties branch 2 times, most recently from 7b0020d to cdbae05 Compare June 17, 2020 12:10
Allow setting the AutomationProperties for HamburgerMenuItem

- AutomationProperties.HelpText
- AutomationProperties.LabeledBy
- AutomationProperties.Name

If Name or HelpText are empty the Label and ToolTip properties will be used.
@punker76 punker76 force-pushed the fix/GH-3839-HamburgerMenu-AutomationProperties branch from cdbae05 to 6ba2db2 Compare June 17, 2020 21:43
…ties

- New HamburgerButtonName property to set AutomationProperties.NameProperty
- New HamburgerButtonHelpText property to set AutomationProperties.HelpTextProperty
@punker76
Copy link
Member Author

@sibille Are these changes enough for Windows Template Studio?

@punker76 punker76 changed the title WIP (GH-3839) Allow setting AutomationProperties for HamburgerMenuItem (GH-3839) Allow setting AutomationProperties for HamburgerMenuItem Jun 18, 2020
@punker76 punker76 merged commit 166d7ab into develop Jun 18, 2020
@punker76 punker76 deleted the fix/GH-3839-HamburgerMenu-AutomationProperties branch June 18, 2020 22:31
@sibille
Copy link

sibille commented Jun 19, 2020

@punker76, yes, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

AutomationProperties for Hamburger Menu
2 participants