Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive RawTextParser asks for excludes twice #3316

Closed
moritz-suckow-mw opened this issue May 25, 2023 · 0 comments · Fixed by #3405
Closed

Interactive RawTextParser asks for excludes twice #3316

moritz-suckow-mw opened this issue May 25, 2023 · 0 comments · Fixed by #3405
Assignees
@Nereboss
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue pr-analysis Issues that touch the analysis pr(oject). priority:high Set by PO

Comments

@moritz-suckow-mw
Copy link
Collaborator

Bug

Expected Behavior

WHEN

using the interactive shell, selecting the RawTextParser and answering the questions

THEN

I get asked for every configuration option once.

Actual Behavior

I get asked Do you want to exclude file/folder according to regex pattern? twice.

Notes

I looked into the code quickly and saw that the RawTextParser uses the same text for the parameters excludes and fileExtensions. This was probably just forgotten to change after copy-pasting?
@moritz-suckow-mw moritz-suckow-mw added bug Only issues that describe bugs. pr-analysis Issues that touch the analysis pr(oject). difficulty:low Solving this is likely not that difficult labels May 25, 2023
@Nereboss Nereboss self-assigned this Nov 8, 2023
Nereboss added a commit that referenced this issue Nov 9, 2023
@Nereboss
Resolve issues with question about filetype #3316
1580313 
Adjusted the asked question as well as the functions returns to work in interactive mode
Nereboss added a commit that referenced this issue Nov 9, 2023
@Nereboss
Add more tests for MetricCollector #3316
d3e395f 
Specifically about the file extension option
Nereboss added a commit that referenced this issue Nov 10, 2023
@Nereboss
Adjust RawTextParser to correctly handle filetypes #3316
c15190d 
Can handle multiple file extensions and file extensions starting with a dot
Nereboss added a commit that referenced this issue Nov 10, 2023
@Nereboss
Adjust behaviour of metricCollector #3316
e6832d6 
Does not produce an outout file when file extensions could not be found; also updated tests for this
Nereboss added a commit that referenced this issue Nov 10, 2023
@Nereboss
Added tests for RawTextParser for invalid file type #3316
b1790be
Nereboss added a commit that referenced this issue Nov 13, 2023
@Nereboss
Adjust RawTextParser to correctly handle invalid file types #3316
103045d 
Added warnings when a file extension was not found; also added multiple tests for that
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Fix assertions for invalid extension tests #3316
1d0bfc1
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Adjust outputfile for added sample project file #3316
3598b29
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Replace error prints with logger calls #3316
9580f16
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Add tests for error logging #3316
37f71c6
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Adjust condition to match linting style #3316
d7be07d
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Adjust tests for added file to sampleproject #3316
73f489d
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Adjust tests for added file to sampleproject #3316
412511b
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Calrify questions for file-extensions and output-file #3316
07e5774
fritschldwg added a commit that referenced this issue Nov 14, 2023
@fritschldwg
Update documentation to include file-extensions #3316
e500d75
@Nereboss Nereboss mentioned this issue Nov 15, 2023
Merged
Nereboss added a commit that referenced this issue Nov 15, 2023
@Nereboss
Adjust Readme and parser dialog #3316
a7f1bab
Nereboss added a commit that referenced this issue Nov 16, 2023
@Nereboss
Small refactor against code smell found by sonar #3316
8522ff2
Nereboss added a commit that referenced this issue Nov 17, 2023
@Nereboss
Refactor naming of file extension in sample project #3316
2e68c80 
Also changed the assertion used to compare json files
Nereboss added a commit that referenced this issue Nov 17, 2023
@Nereboss
Move part of call function into helper function #3316
69656ba
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Update flag and readme for rawtextparser #3316
7f9f877
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Update readme and gh-pages #3316
22a7f88
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Fix typo in readme and gh-pages #3316
c45ee3e
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Add missing parameter to gh-pages #3316
5b4e520
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Update flag and readme for rawtextparser #3316
02962c5
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Update readme and gh-pages #3316
1887c68
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Fix typo in readme and gh-pages #3316
72d961f
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Add missing parameter to gh-pages #3316
6f368b4
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Fix rebase conflicts #3316
35cb98b
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Resolve issues with question about filetype #3316
7d79fd2 
Adjusted the asked question as well as the functions returns to work in interactive mode
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Add more tests for MetricCollector #3316
7e797f4 
Specifically about the file extension option
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Adjust RawTextParser to correctly handle filetypes #3316
6b34d48 
Can handle multiple file extensions and file extensions starting with a dot
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Adjust behaviour of metricCollector #3316
01b4a9c 
Does not produce an outout file when file extensions could not be found; also updated tests for this
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Added tests for RawTextParser for invalid file type #3316
24ba171
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Adjust RawTextParser to correctly handle invalid file types #3316
eeaa917 
Added warnings when a file extension was not found; also added multiple tests for that
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Fix assertions for invalid extension tests #3316
eafb297
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Adjust outputfile for added sample project file #3316
76486ff
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Replace error prints with logger calls #3316
d2971b1
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Add tests for error logging #3316
3381ef1
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Adjust condition to match linting style #3316
e5d0d30
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Adjust tests for added file to sampleproject #3316
22d80a7
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Adjust tests for added file to sampleproject #3316
6bc19f0
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Calrify questions for file-extensions and output-file #3316
5f4e50e
Nereboss pushed a commit that referenced this issue Nov 21, 2023
@fritschldwg @Nereboss
Update documentation to include file-extensions #3316
96968f7
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Fix rebase conflicts #3316
d707f2c
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Small refactor against code smell found by sonar #3316
004e01e
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Refactor naming of file extension in sample project #3316
97850c5 
Also changed the assertion used to compare json files
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Move part of call function into helper function #3316
22eaae8
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Update flag and readme for rawtextparser #3316
56486be
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Update readme and gh-pages #3316
903e97c
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Fix typo in readme and gh-pages #3316
f57d247
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Add missing parameter to gh-pages #3316
25dc459
Nereboss added a commit that referenced this issue Nov 21, 2023
@Nereboss
Fix rebase conflicts #3316
c0c348b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nereboss Nereboss

Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue pr-analysis Issues that touch the analysis pr(oject). priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/3316/rawtextparser asking twice MaibornWolff/codecharta
3 participants
@ce-bo @Nereboss @moritz-suckow-mw