Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/3250/ngrx #3271

Merged
merged 71 commits into from
Apr 28, 2023
Merged

Refactor/3250/ngrx #3271

merged 71 commits into from
Apr 28, 2023

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Apr 13, 2023

  • replace redux through ngrx
  • fix at least one broken memorization leading to a lot of unnecessary calculations
  • Code Smells are copied over todos which already existed before and not related to changes from this PR

close #3250
fix #3268 (which was probably caused by racing conditions)

as map called it with (every event increased by one) index, preventing memoization

ref #3250
@shaman-apprentice
Copy link
Contributor Author

A little bug, where I'm not sure if it is new, is that red colored buildings are never completly red, as there are supposed to be, instead always have a gray part at the bottom. I'm not sure if this is intended or not. Green buildings can be completly green.

Buildings keep their 'selected' color orange in delta mode.

On current released version, selection doesn't go away in delta mode as well. Red buildings also have a little gray bottom. @ce-bo do we already have a bug for the first one? I am not sure if the second one is a bug.
image

@shaman-apprentice shaman-apprentice marked this pull request as ready for review April 23, 2023 09:42
@Hall-Ma
Copy link
Contributor

Hall-Ma commented Apr 23, 2023

I have manually tested some functionalities, which all work as expected:

  • Delta mode including switch maps via the button
  • Flattening buildings
  • Coloring of folders
  • Excluding buildings and folders and then inserting them via the eye button
  • All settings in Color Metric Option Settings, Area Metric Option Settings, Height Metric Option Settings
  • Show legend and change colors
  • Show attribute sidebar and switch median/average via the button
  • Load maps via the file chooser
  • Rotate maps via the Cube
  • Show High-Risk Profile
  • Show Suspicious Metrics and select one via button
  • Height and Size Metric Link Button
  • Search panel (click through the folder structures)
  • Change height, area and color metric
  • Change map layout, resolution, background and experimental features
  • Select buildings/folders on the map
  • maps with edges are shown and edges can be deactivated
  • add custom view and load custom view via panel
  • add and apply metric templates

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Apr 23, 2023

@shaman-apprentice one bug I found was this:

  • load sample maps, apply a suspicious metric that is very high risk (exclamation mark button)
  • then apply metric template for complexity and the colors do not change

In the demo this use case is working. Maybe you can take a look at it?
Thanks for the ngrx implementation! This was a huuuge job! ❤️

@shaman-apprentice
Copy link
Contributor Author

@shaman-apprentice one bug I found was this:

  • load sample maps, apply a suspicious metric that is very high risk (exclamation mark button)
  • then apply metric template for complexity and the colors do not change

Good catch. Fixed. I forgot to use default value, when undefined is dispatched. I fixed it for map colors.

In a future commit I will fix it for every action, which had it previously.

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

91.9% 91.9% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@shaman-apprentice shaman-apprentice merged commit d46fa03 into main Apr 28, 2023
@shaman-apprentice shaman-apprentice deleted the refactor/3250/ngrx branch April 28, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delta Mode not working anymore Migrate redux to NgRx
3 participants