-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/3250/ngrx #3271
Refactor/3250/ngrx #3271
Conversation
as map called it with (every event increased by one) index, preventing memoization ref #3250
…nd accordingly adjust assertions ref #3250
On current released version, selection doesn't go away in delta mode as well. Red buildings also have a little gray bottom. @ce-bo do we already have a bug for the first one? I am not sure if the second one is a bug. |
I have manually tested some functionalities, which all work as expected:
|
@shaman-apprentice one bug I found was this:
In the demo this use case is working. Maybe you can take a look at it? |
Good catch. Fixed. I forgot to use default value, when undefined is dispatched. I fixed it for map colors. In a future commit I will fix it for every action, which had it previously. |
0b4fe33
to
d9cb7a6
Compare
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
close #3250
fix #3268 (which was probably caused by racing conditions)