Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch color range on color metric change #3309 #3311

Merged
merged 7 commits into from
Jun 2, 2023

Conversation

jannikr
Copy link
Contributor

@jannikr jannikr commented May 22, 2023

Dispatch color range on color metric change

Issue: #3309

Description

  • fix color range bug on color metric change
  • automatically handle color range on color metric change
  • accept small values eg 5 (screenshot)

Screenshots or gifs

Before After

@jannikr jannikr marked this pull request as ready for review May 22, 2023 13:18
@jannikr jannikr marked this pull request as draft May 22, 2023 14:52
@jannikr jannikr marked this pull request as ready for review May 23, 2023 06:34
@phanlezz phanlezz linked an issue May 25, 2023 that may be closed by this pull request
@phanlezz phanlezz force-pushed the fix/3309/fetch-node-metric-range-on-metric-change branch from eecc2fa to 6b3947d Compare May 25, 2023 07:26
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phanlezz phanlezz merged commit 0ee9887 into main Jun 2, 2023
@phanlezz phanlezz deleted the fix/3309/fetch-node-metric-range-on-metric-change branch June 2, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Metric Options not configurable for metrics with small values
3 participants