Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/3326/fix-directly-run-interactive-parser #3332

Merged
merged 8 commits into from
Jun 22, 2023

Conversation

moritz-suckow-mw
Copy link
Collaborator

Add automatic running of interactive parser when no args are specified

Issue: #3326

Description

This adds automatic running of the interactive parser dialog if you call a specific parser but with no arguments, e.g. ccsh sonarimport.

Note

Would it make sense to also add this whenever insufficient arguments are provided and not only none?

@phanlezz
Copy link
Collaborator

I have some trouble to get it running on my local windows machines. I need to investigate before merging

@phanlezz
Copy link
Collaborator

phanlezz commented Jun 21, 2023

Can't compile it currently, because there is a failing gitlogparser test. (repo-scan)
The execution stops right towards the end at around 80%.
It seems like the problem is, that the produced git log is not finished / complete.

Strangely, this seems to be a problem with this branch, as even the released main version is unable to repo-scan this branch. When the git log is produced standalone and then scanned in, everything works as intended.

Incomplete git log
grafik
How it should look like
grafik

When someone has an idea feel free to comment

@ce-bo
Copy link
Collaborator

ce-bo commented Jun 22, 2023

Few ideas/points to check:

  • do you have enough disk space?
  • the line endings are different between the two screenshots
  • Are you able to use the GitLogParser in the main branch to parse another branch?
  • How much bytes are written to this temp file? Are there limitations of the used FileWriter approach like in terms size limitations?

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.5% 93.5% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phanlezz phanlezz merged commit 38ee1b7 into main Jun 22, 2023
@phanlezz phanlezz deleted the fix/3326/fix-directly-run-interactive-parser branch June 22, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants